Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VQE implementation with estimator primitive #8702
VQE implementation with estimator primitive #8702
Changes from 97 commits
0a35c1a
ac88412
3fd8f3c
9b987cc
378aac8
629e6de
499c35e
689e2c8
1a43460
8d6bd1c
f1ffb54
fcb2846
903614c
27d02b0
813a344
70ba38b
36dfd3b
3c79faa
4695cc3
105c5db
9131190
c726397
cfdea10
68788ca
7ab77e4
632b3aa
6aa5373
a002467
c83c7b9
98648f0
2ed3ff3
aced280
9459603
3623ad7
93213dc
5defcd5
b7c4a74
af47dea
f682616
16dc12c
994247b
688f9f1
a9d6d41
6e99b34
6abff88
0b5c185
e2dafa8
1eb2329
c05cdbc
4cbbe67
455981c
ae66409
3c17862
067cd07
3acf449
b3db998
1990045
86e7b86
bd0c97d
7cdd399
c204a7e
91fe427
7afa7eb
ac2871a
0e0a5d4
8d238bf
a2cd35a
4dab8bc
78d21c5
d9f5cb2
eaea3e6
183c20c
d01d47b
f06a74c
9cfb1b2
3ec9dba
4d7a0fd
4a16903
6a15540
4fdf4f5
355d887
b0b8f37
c144688
8fed152
682d3cb
2976ac9
998121f
8aeed79
483fbd2
7e2ee3d
31219bf
511caca
34246d3
12f6426
efc0565
b1c55ca
50eba6d
18b5b63
0e0ebac
3357ebe
66ba346
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure whether it requires
| None
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The prior signature was
I imagine this is saying that the filter criteria is applied to the aux ops result which may be None. I would have thought the filter would not have needed to be called in this case but this is how it has been.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change made in the commit that addresses your comment below.