Command/Inst refactor: Delay #3924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…struction, while maintaining support for the previous API
lcapelluto
requested review from
ajavadia,
DanPuzzuoli,
diego-plan9,
eggerdj,
kdk,
mtreinish,
nkanazawa1989 and
taalexander
as code owners
taalexander
previously approved these changes
Mar 5, 2020
lcapelluto
commented
Mar 9, 2020
taalexander
previously approved these changes
Mar 9, 2020
…qiskit-terra into issue-3750-delay-instruction
taalexander
previously approved these changes
Mar 10, 2020
mtreinish
reviewed
Mar 11, 2020
releasenotes/notes/unify-instructions-and-commands-aaa6d8724b8a29d3.yaml
Show resolved
Hide resolved
mtreinish
previously approved these changes
Mar 11, 2020
taalexander
previously approved these changes
Mar 11, 2020
mtreinish
approved these changes
Mar 11, 2020
taalexander
approved these changes
Mar 11, 2020
lcapelluto
added
the
Changelog: API Change
faisaldebouni
pushed a commit
to faisaldebouni/qiskit-terra
that referenced
this pull request
Aug 5, 2020
* Migrate Delay from a Command to an Instruction, and deprecate DelayInstruction, while maintaining support for the previous API * Scattering of bugfixes * Remove extra line * Add reno note update * Add new test * Update qiskit/pulse/instructions/delay.py * Fix up releasenote, single : to double :: * Give instructions a default name * Update releasenote as a deprecation * Fixup release notes typo: deprecation needs to be plural Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Part 3/7 for #3750
Delaythe command becomesDelaythe instruction,DelayInstructionis deprecated.Details and comments
Pretty straightforward drop in replacement. Cannot just timeslots.duration for duration, because an Instruction without channels doesn't have timeslots, and
Delayneeds to support being instantiated without channels and still having adurationto pass when the channel is supplied.