Improving legacy swapper performance #2525
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1ucian0
requested review from
ajavadia,
atilag,
chriseclectic,
delapuente,
diego-plan9,
ewinston,
jaygambetta,
kdk,
mtreinish,
nonhermitian and
taalexander
as code owners
added 3 commits
May 28, 2019 16:02
Closed
|
I think this is irrelevant now with #2670 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of #2499 (comment), I was investigating possible reasons. The main problem seems in
LegacySwap.layer_permutation, in master:And before #2414
Indeed, the problem is the amount of equality checks among qubits. So, this PR tries to improve that. Additionally, I found other points of improvement (for example, by reducing the amount of equality comparison). The result is the following:
Note that equality check for
Bitis expensive (in part, because the deprecation warnings) and this PR bearly address that. But I could counter effect that price by other improvements.