Fix ignored errors/durations in generate_preset_pass_manager if dt is set (backport #14065)
#14098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
…` is set (#14065) * Fix dt oversight in generate_preset_pass_manager * Update warning to mention explicitly the invalidation of custom durations and error rates. * Do not overwrite original backend values inside transpile, iterate over target to reset internal instruction_durations value so that new dt can be taken into account * One iteration is enough to reset the value of self._instruction_durations * Estimate duration instead of hardcoding it * Apply suggestion from Matt's code review Co-authored-by: Matthew Treinish <mtreinish@kortar.org> * Fix example * Move cache invalidation to target dt setter. * Add reno --------- Co-authored-by: Matthew Treinish <mtreinish@kortar.org> (cherry picked from commit 6ce7788)
|
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the following people are relevant to this code:
|
github-actions
bot
added
Changelog: Bugfix
Pull Request Test Coverage Report for Build 14068444742Details
💛 - Coveralls |
mtreinish
approved these changes
Mar 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
#14056 (comment) reported an unexpected behavior of
generate_preset_pass_managerwhere setting a customdtwould invalidate the backend's gate durations and error rates. This was due to an oversight in #9256 , where a custom target would be built from scratch usingTarget.from_configurationwhenever any loose constraint was set, and any information regarding instruction properties would be lost. This was intentional forcoupling_mapandbasis_gates, as they modify the target gate map, but not necessary fordt, where the target could be kept and simply updated.This PR fixes this use case, adds a test with vf2 + dt, and modifies the user warning to explicitly communicate what will happen with gate durations and errors if
coupling_maporbasis_gatesare set with abackend.Details and comments
The changelog is None as #9256 has not been released yet.
This is an automatic backport of pull request #14065 done by [Mergify](https://mergify.com).