Missing release note in #13890 #13962
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One or more of the following people are relevant to this code:
|
mtreinish
reviewed
Mar 5, 2025
There was a problem hiding this comment.
This actually isn't needed here. We would just delete the release not for 2.0.0 because it'll already get published as part of the 1.4.1 release. After 2.0 we would probably want this so we could document the fix on both 1.4.2 and 2.0.1, but beforehand it's assumed that 2.0.0 includes everything from 1.4.1 so we typically only want one release note.
Pull Request Test Coverage Report for Build 13678336497Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
While working in 1.4.1, I noticed that the PR #13890 was missing a release note.