-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend deprecation of QuantumCircuit.duration and DAGCircuit.duration #13960
Extend deprecation of QuantumCircuit.duration and DAGCircuit.duration #13960
Conversation
Since we're unlikely to be able to include these removals as part of Qiskit 2.0.0 given the dependencies on them and that the removals are not critical for any work we have in the 2.x series this commit opts to just update the deprecation message to say the removal will occur in Qiskit 3.0.0 not 2.0.0 like was originally planned.
One or more of the following people are relevant to this code:
|
Pull Request Test Coverage Report for Build 13676091912Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just one minor question about the release notes: we are suggesting to use :meth:.QuantumCircuit.estimate_duration
for DAGCircuit
s as well?
We are as the method isn't publicly exposed for |
Actually I remember now it wasn't straightforward to add it to DAGCircuit. The issue is that |
Summary
Since we're unlikely to be able to include these removals as part of Qiskit 2.0.0 given the dependencies on them and that the removals are not critical for any work we have in the 2.x series this commit opts to just update the deprecation message to say the removal will occur in Qiskit 3.0.0 not 2.0.0 like was originally planned.
Details and comments