-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New atomic_evolution
signature in ProductFormula
subclasses
#13918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
One or more of the following people are relevant to this code:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This basically LGTM, just one minor nit pick on the reno.
--- | ||
upgrade_synthesis: | ||
- | | ||
The ``atomic_evolution`` argument to :class:`.ProductFormula` (and its |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you want to be exhaustive, you should also include LieTrotter
as a subclass here.
Pull Request Test Coverage Report for Build 13588705593Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Fixes #13858
Summary
Removes the types, the deprecations, and readjust the test.
Details and comments
Probably makes sense that @mrossinek takes a look to this.