Skip to content

New atomic_evolution signature in ProductFormula subclasses #13918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 28, 2025

Conversation

1ucian0
Copy link
Member

@1ucian0 1ucian0 commented Feb 24, 2025

Fixes #13858

Summary

Removes the types, the deprecations, and readjust the test.

Details and comments

Probably makes sense that @mrossinek takes a look to this.

@1ucian0 1ucian0 requested a review from a team as a code owner February 24, 2025 17:00
@qiskit-bot
Copy link
Collaborator

One or more of the following people are relevant to this code:

  • @Cryoris
  • @Qiskit/terra-core
  • @ajavadia

@1ucian0 1ucian0 added this to the 2.0.0 milestone Feb 24, 2025
mrossinek
mrossinek previously approved these changes Feb 25, 2025
Copy link
Member

@mrossinek mrossinek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This basically LGTM, just one minor nit pick on the reno.

---
upgrade_synthesis:
- |
The ``atomic_evolution`` argument to :class:`.ProductFormula` (and its
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want to be exhaustive, you should also include LieTrotter as a subclass here.

@Cryoris Cryoris enabled auto-merge February 28, 2025 13:02
@Cryoris Cryoris added this pull request to the merge queue Feb 28, 2025
@coveralls
Copy link

Pull Request Test Coverage Report for Build 13588705593

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 725 unchanged lines in 37 files lost coverage.
  • Overall coverage increased (+0.1%) to 88.119%

Files with Coverage Reduction New Missed Lines %
qiskit/pulse/builder.py 1 85.31%
qiskit/pulse/instructions/reference.py 1 90.32%
qiskit/transpiler/passes/layout/apply_layout.py 1 98.21%
qiskit/transpiler/passes/layout/dense_layout.py 1 95.12%
qiskit/user_config.py 1 86.87%
crates/accelerate/src/unitary_synthesis.rs 3 94.29%
qiskit/circuit/classical/expr/expr.py 4 96.67%
qiskit/circuit/library/arithmetic/integer_comparator.py 4 94.67%
qiskit/circuit/library/phase_oracle.py 4 85.71%
qiskit/synthesis/evolution/product_formula.py 4 85.11%
Totals Coverage Status
Change from base Build 13503270954: 0.1%
Covered Lines: 77522
Relevant Lines: 87974

💛 - Coveralls

Merged via the queue into Qiskit:main with commit 59d910e Feb 28, 2025
19 checks passed
@ElePT ElePT added the Changelog: API Change Include in the "Changed" section of the changelog label Mar 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: API Change Include in the "Changed" section of the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove deprecated input type in atomic_evolution
6 participants