Remove the classical_function module and all tweedledum-related code
#13815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gadial
added
the
Changelog: Removal
|
One or more of the following people are relevant to this code:
|
| @@ -1371,105 +1370,5 @@ def test_cswap_reg_reg_inv(self): | |||
| self.assertEqual(instruction_set[1].qubits, (self.qr[1], self.qr2[1], self.qr3[1])) | |||
| self.assertEqual(instruction_set[2].operation.params, []) | |||
|
|
|||
|
|
|||
| class TestStandardMethods(QiskitTestCase): | |||
There was a problem hiding this comment.
can we do these tests with PhaseOracle w/o tweedledum ?
There was a problem hiding this comment.
Yes, actually tweedledum was not really needed there. I returned the test.
| return a and b and not c | ||
|
|
||
| circuit = grover_oracle.synth(registerless=False) | ||
| self.assertEqual(str(circuit_drawer(circuit, output="text", initial_state=True)), expected) |
There was a problem hiding this comment.
can we still do this tests with grover or phase oracle w/o tweedledum ?
There was a problem hiding this comment.
It doesn't make sense, since this is a test for registerless synthesis, which is currently not supported by the oracles.
|
|
mtreinish
changed the title
classical_function module and all tweedledum-related codeclassical_function module and all tweedledum-related code
Cryoris
reviewed
Feb 26, 2025
releasenotes/notes/remove_classical_function-7d9057bc5c77d268.yaml
Outdated
Show resolved
Hide resolved
…yaml Co-authored-by: Julien Gacon <gaconju@gmail.com>
Pull Request Test Coverage Report for Build 13551023854Details
💛 - Coveralls |
1ucian0
approved these changes
Feb 27, 2025
mtreinish
added a commit
to mtreinish/qiskit-core
that referenced
this pull request
Mar 1, 2025
In Qiskit#13815 the usage of the tweedledum library was removed from Qiskit. The classes that used this functionality was deprecated in 1.4.0, but the optional library checker was not deprecated. These optionals checkers are part of the public API and would have needed a deprecation before removal as there may be downstream users of the checker. This commit restores the checker, but alters the docstring to make it clear that tweedledum isn't used by Qiskit anymore. If we want to remove the checker in 3.0 we can deprecate it in 2.1.0 or another release in the 2.x series. Although, there is basically no real cost for keeping it around so it's probably not worth the effort.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 1, 2025
In #13815 the usage of the tweedledum library was removed from Qiskit. The classes that used this functionality was deprecated in 1.4.0, but the optional library checker was not deprecated. These optionals checkers are part of the public API and would have needed a deprecation before removal as there may be downstream users of the checker. This commit restores the checker, but alters the docstring to make it clear that tweedledum isn't used by Qiskit anymore. If we want to remove the checker in 3.0 we can deprecate it in 2.1.0 or another release in the 2.x series. Although, there is basically no real cost for keeping it around so it's probably not worth the effort.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Removes from qiskit the
classical_functionmodule and all code that relies on thetweedledumlibrary.Closes #13755
Details and comments
The
tweedledumlibrary is not compatible with new versions of Python, so reliance on it has to be dropped in Qiskit 2.0. Since theclassical_functionmodule basically servers as a qiskit wrapper fortweedledumfunctionality, we remove it from qiskit, after its deprecation in #13786.To preserve the main functionality of
classical_function, i.e. the ability to generate phase and bit-flip oracles from boolean expressions, we add a simple,tweedledum-independent implementation in #13769, which is placed inqiskit.synthesis.booleaninstead of theclassical_functionmodule. This PR relies on #13769 being merged, otherwise the existing tests forPhaseOraclewill not pass.