Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add documentation about instruction duration #13592

Merged
merged 8 commits into from
Feb 20, 2025

Conversation

1ucian0
Copy link
Member

@1ucian0 1ucian0 commented Dec 21, 2024

Summary

The deprecations introduced in #13247 did not notify via docs.

@coveralls
Copy link

coveralls commented Dec 21, 2024

Pull Request Test Coverage Report for Build 13439416061

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 16 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.01%) to 88.105%

Files with Coverage Reduction New Missed Lines %
crates/qasm2/src/lex.rs 4 92.98%
crates/qasm2/src/parse.rs 12 97.15%
Totals Coverage Status
Change from base Build 13433680747: -0.01%
Covered Lines: 78338
Relevant Lines: 88914

💛 - Coveralls

@1ucian0 1ucian0 marked this pull request as ready for review December 24, 2024 14:09
@1ucian0 1ucian0 requested review from nonhermitian, a team, eggerdj and wshanks as code owners December 24, 2024 14:09
@qiskit-bot
Copy link
Collaborator

One or more of the following people are relevant to this code:

@1ucian0 1ucian0 added documentation Something is not clear or an error documentation Changelog: None Do not include in changelog labels Dec 24, 2024
Copy link
Contributor

@ElePT ElePT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I just added some minor grammatical suggestions.

1ucian0 and others added 2 commits January 21, 2025 11:03
Co-authored-by: Elena Peña Tapia <57907331+ElePT@users.noreply.github.com>
@1ucian0 1ucian0 added this to the 1.4.0 milestone Feb 20, 2025
@1ucian0 1ucian0 self-assigned this Feb 20, 2025
ElePT
ElePT previously approved these changes Feb 20, 2025
Copy link
Contributor

@ElePT ElePT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one typo

ElePT
ElePT previously approved these changes Feb 20, 2025
@ElePT ElePT enabled auto-merge February 20, 2025 14:20
ElePT
ElePT previously approved these changes Feb 20, 2025
@ElePT ElePT added this pull request to the merge queue Feb 20, 2025
Merged via the queue into Qiskit:main with commit 83c20e9 Feb 20, 2025
17 checks passed
@ElePT
Copy link
Contributor

ElePT commented Feb 21, 2025

@Mergifyio backport stable/1.4

@ElePT ElePT added the stable backport potential The bug might be minimal and/or import enough to be port to stable label Feb 21, 2025
mergify bot pushed a commit that referenced this pull request Feb 21, 2025
* add docuemntation about instruction duration

* more docs and some spelling

* Apply suggestions from code review

Co-authored-by: Elena Peña Tapia <57907331+ElePT@users.noreply.github.com>

* Update qiskit/circuit/instruction.py

* Fix black

* Fix lint

---------

Co-authored-by: Elena Peña Tapia <57907331+ElePT@users.noreply.github.com>
Co-authored-by: Elena Peña Tapia <epenatap@gmail.com>
(cherry picked from commit 83c20e9)
github-merge-queue bot pushed a commit that referenced this pull request Feb 21, 2025
* add docuemntation about instruction duration

* more docs and some spelling

* Apply suggestions from code review

Co-authored-by: Elena Peña Tapia <57907331+ElePT@users.noreply.github.com>

* Update qiskit/circuit/instruction.py

* Fix black

* Fix lint

---------

Co-authored-by: Elena Peña Tapia <57907331+ElePT@users.noreply.github.com>
Co-authored-by: Elena Peña Tapia <epenatap@gmail.com>
(cherry picked from commit 83c20e9)

Co-authored-by: Luciano Bello <bel@zurich.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: None Do not include in changelog documentation Something is not clear or an error documentation stable backport potential The bug might be minimal and/or import enough to be port to stable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants