Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecation of MCMT in favor of MCMTGate #13584

Merged
merged 4 commits into from
Feb 7, 2025
Merged

Deprecation of MCMT in favor of MCMTGate #13584

merged 4 commits into from
Feb 7, 2025

Conversation

1ucian0
Copy link
Member

@1ucian0 1ucian0 commented Dec 19, 2024

The Multiple-Control-Multiple-Target in qiskit.circuit.library.generalized_gates.MCMT was pending for deprecation in #13150 . This PR moves it to deprecated.

@1ucian0 1ucian0 requested a review from a team as a code owner December 19, 2024 17:38
@qiskit-bot
Copy link
Collaborator

One or more of the following people are relevant to this code:

  • @Cryoris
  • @Qiskit/terra-core
  • @ajavadia

@1ucian0 1ucian0 mentioned this pull request Dec 19, 2024
Closed
@1ucian0 1ucian0 added this to the 1.4.0 milestone Dec 19, 2024
@1ucian0 1ucian0 added the Changelog: Deprecation Include in "Deprecated" section of changelog label Dec 19, 2024
@1ucian0 1ucian0 mentioned this pull request Dec 20, 2024
Closed
40 tasks
@Cryoris Cryoris added on hold Can not fix yet and removed on hold Can not fix yet labels Dec 20, 2024
@Cryoris
Copy link
Contributor

Cryoris commented Dec 20, 2024

I think we want to deprecate the circuit library objects for 1.4 and 2.0, but might not want to remove them for 2.0. Even though this PR only changes from PendingDeprecationWarning to DeprecationWarning, we probably should discuss what the exact plan is 🙂

@1ucian0 1ucian0 removed the on hold Can not fix yet label Dec 24, 2024
Cryoris
Cryoris requested changes Feb 5, 2025
View reviewed changes
Copy link
Contributor

@Cryoris Cryoris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I was too eager to approve -- this should actually be merged both into 2.0 and 1.4 since we want to keep the MCMT circuit (and all other library objects) deprecated throughout the 2.0 cycle and only remove them in 3.0.

@Cryoris Cryoris changed the base branch from stable/1.4 to main February 5, 2025 18:05
@Cryoris Cryoris changed the base branch from main to stable/1.4 February 5, 2025 18:06
@1ucian0 1ucian0 changed the base branch from stable/1.4 to main February 5, 2025 21:14
@1ucian0 1ucian0 changed the base branch from main to stable/1.4 February 5, 2025 21:26
@1ucian0 1ucian0 changed the base branch from stable/1.4 to main February 5, 2025 21:34
@1ucian0
Copy link
Member Author

1ucian0 commented Feb 5, 2025

@Mergifyio backport stable/1.4

@mergify Mergify
Copy link
Contributor

mergify bot commented Feb 5, 2025 •
edited
Loading

backport stable/1.4

✅ Backports have been created

Cryoris
Cryoris previously approved these changes Feb 6, 2025
View reviewed changes
Copy link
Contributor

@Cryoris Cryoris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@coveralls
Copy link

Pull Request Test Coverage Report for Build 13178622519

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 8 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.004%) to 88.613%
Files with Coverage Reduction New Missed Lines %
crates/accelerate/src/unitary_synthesis.rs 1 92.97%
crates/qasm2/src/expr.rs 1 94.23%
crates/qasm2/src/lex.rs 6 91.73%
Totals Coverage Status
Change from base Build 13177262403: -0.004%
Covered Lines: 79351
Relevant Lines: 89548
💛 - Coveralls

@Cryoris Cryoris added this pull request to the merge queue Feb 7, 2025
Merged via the queue into Qiskit:main with commit 28a33d7 Feb 7, 2025
17 checks passed
mergify bot pushed a commit that referenced this pull request Feb 7, 2025
@1ucian0 @mergify
Deprecation of MCMT in favor of MCMTGate (#13584)
d0a205c 
* remove pending deprecations in mcmt

* reno

* testing a regression

(cherry picked from commit 28a33d7)

# Conflicts:
#	test/python/circuit/library/test_mcmt.py
@mergify mergify bot mentioned this pull request Feb 7, 2025
Merged
@1ucian0 1ucian0 deleted the followup/13150/1 branch February 10, 2025 15:37
github-merge-queue bot pushed a commit that referenced this pull request Feb 14, 2025
@mergify @1ucian0 @ElePT
Deprecation of MCMT in favor of MCMTGate (backport #13584) (#13810)
4f4de71 
* Deprecation of MCMT in favor of MCMTGate (#13584)

* remove pending deprecations in mcmt

* reno

* testing a regression

(cherry picked from commit 28a33d7)

# Conflicts:
#	test/python/circuit/library/test_mcmt.py

* Fix conflict

---------

Co-authored-by: Luciano Bello <bel@zurich.ibm.com>
Co-authored-by: Elena Peña Tapia <57907331+ElePT@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cryoris Cryoris Cryoris approved these changes

@alexanderivrii alexanderivrii Awaiting requested review from alexanderivrii

@ShellyGarion ShellyGarion Awaiting requested review from ShellyGarion

@jyu00 jyu00 Awaiting requested review from jyu00

@nonhermitian nonhermitian Awaiting requested review from nonhermitian

@eggerdj eggerdj Awaiting requested review from eggerdj

@wshanks wshanks Awaiting requested review from wshanks

Assignees

@Cryoris Cryoris

Labels
Changelog: Deprecation Include in "Deprecated" section of changelog
Projects
None yet
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.
4 participants
@1ucian0 @qiskit-bot @Cryoris @coveralls