Deprecate BasicAer and introduce BasicProvider
#11583
Conversation
Co-authored-by: Julien Gacon <gaconju@gmail.com>
ElePT
added
the
Changelog: Deprecation
ElePT
added
the
Changelog: New Feature
ElePT
requested review from
ikkoham,
t-imamichi,
a team,
alexanderivrii,
ShellyGarion,
jyu00 and
woodsp-ibm
as code owners
|
One or more of the the following people are requested to review this:
|
Co-authored-by: Julien Gacon <gaconju@gmail.com>
Co-authored-by: Matthew Treinish <mtreinish@kortar.org>
There was a problem hiding this comment.
Thanks for the quick update. I think this is basically ready, I just had two super small comments that I caught on my final pass through, one small one about the docstring for the new simulator class and the other about the usage of rngs in numpy using the legacy interface.
| self._configuration = None | ||
|
|
||
| # Internal simulator variables | ||
| self._local_random = np.random.RandomState() |
There was a problem hiding this comment.
This is actually the legacy interface for numpy random number generators. We probably should use the newer interface: https://numpy.org/doc/stable/reference/random/generator.html there are some small changes needed but it shouldn't be too bad.
There was a problem hiding this comment.
I was not sure about making this change because the number generation algorithm is different with the new interface. At least, I have not found a way to generate the same values with the same seed (I noticed this when migrating algorithm_globals). But I keep forgetting that this is technically a new class, so that is technically not a behavior change.
Co-authored-by: Matthew Treinish <mtreinish@kortar.org>
…-terra into deprecate-basic-aer
Summary
This PR introduces
BasicProviderin the 0.46 branch (analogous to #11422 in the main branch but up-to-date with 0.46 changes), and raises deprecation warnings forBasicAer.The migration path from
BasicAertoBasicProvideris summarized in both the release note and as a warning in the corresponding API doc entry.Details and comments
The fact that most users access the basic aer provider via its global instance +
get_backendmade the deprecation trickier than usual. To make sure that a warning would always be seen, this PR inserts not only deprecation decorators in the class inits (to be raised when instantiated directly), but also a deprecation warning to be raised uponfrom qiskit import BasicAer.