Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude non-rc pre-releases from qpy backwards compat tests (backport #11572) #11574

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jan 16, 2024

This is an automatic backport of pull request #11572 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

The QPY backwards compatibility tests are setup to verify that we can
load qpy files generated with historical releases using the current
version of Qiskit under development. This ensures we're meeting our
backwards compatibility guarantees with QPY. However, the tests were
over eagerly running on pre-releases that don't have any stability
guarantees, mainly alpha and beta releases indicated by "a" and "b"
suffixes respectively in the version number. This commit excludes
these pre-release versions from the tests as it's not valid to
run with these. Release candidate pre-releases should still be run
because they have stable APIs and they're not skipped by this PR.

(cherry picked from commit abb803f)
@mergify mergify bot requested a review from a team as a code owner January 16, 2024 18:17
@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the the following people are requested to review this:

  • @Qiskit/terra-core
  • @mtreinish
  • @nkanazawa1989

@github-actions github-actions bot added type: qa Issues and PRs that relate to testing and code quality Changelog: None Do not include in changelog labels Jan 16, 2024
@github-actions github-actions bot added this to the 0.45.2 milestone Jan 16, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 7545834201

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 86.952%

Totals Coverage Status
Change from base Build 7533371088: 0.03%
Covered Lines: 74243
Relevant Lines: 85384

💛 - Coveralls

@mtreinish mtreinish added this pull request to the merge queue Jan 16, 2024
Merged via the queue into stable/0.45 with commit 0055340 Jan 17, 2024
14 checks passed
@mergify mergify bot deleted the mergify/bp/stable/0.45/pr-11572 branch January 17, 2024 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: None Do not include in changelog type: qa Issues and PRs that relate to testing and code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants