-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing monitor tools #11414
Fixing monitor tools #11414
Conversation
Copying in some discussion from offline: imo these functions aren't suitable for core Qiskit; information about queue positions and reading custom downstream fields from a |
I agree with @jakelishman, moving this functionality out of qiskit would also be coherent with the changes laid out in #10266 (the fake backend epic). |
This commit deprecates the qiskit.tools module. Most of the functionality in this module will be removed in the Qiskit 1.0.0 release. The sole exception is the qiskit.tools.parallel module and it's associated public function qiskit.tools.parallel_map which has been moved to qiskit.utils.
9083f29
to
5e16db2
Compare
It makes total sense what you are both saying. I changed the base to |
…te/backend_overview/1
I'm merging the |
One or more of the the following people are requested to review this:
|
#11514 is merged now, removing hold. |
Given the timeframe for the 0.46.0 release I've deferred this to 0.46.1, it's a valid bugfix for a patch release too. |
…dOverview.test_backend_monitor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. The changes seem low risk given that the module they address does not currently work.
The tools in
qiskit.tools.monitor
are a bit neglected. This PR is trying to bring them up to speed.qiskit.tools.monitor.job_monitor
Closes #7865
job_monitor
now works withRuntimeJob
.JobV1
does not providequeue_position
so a generaljob_monitor
should not assume it (probably was only a thing withIBMJob
. Ifjob_monitor
stays in Qiskit, it should be generic.qiskit.tools.monitor.backend_monitor
It was not working at all, so now it works. In the future, it should work with any
BackendV2
or be moved toqiskit-ibm-runtime
otherwise.qiskit.tools.monitor.backend_overview
Similarly to
qiskit.tools.monitor.backend_monitor
, it was not working at all, so now it works. In the future, it should take aBackendV2
or be moved toqiskit-ibm-runtime
otherwise.TODO:if we keep them, a bugfix reno.we keep it in the0.*
majorif we dont keep them, deprecate/remove them