-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove pylatexenc as required dependency #2417
Comments
Well that's not entirely the case, we also have pillow in requirements which is also only used for latex drawing. The thing which is optional is the external dependencies like pdflatex and the latex requirements (because we don't have a mechanism to require them). I'd actually argue that pillow should be optional but not pylatexenc, mostly because pylatexenc is used by the latex_source backend which has no other external dependencies and just returns a string. |
pillow should also be optional. |
The pylatexenc and pillow requirements are only used in the latex and latex_source circuit drawers. Since this isn't used by everyone and is a non-default circuit drawer there is no reason we should force our users to install these by default. This commit updates the requirements list and setup.py to make these 2 requirements optional and included in the visualization setuptools extras to ease installation. If the packages are not installed it will raise an ImportError with a detailed exception explaining how to install the missing dependency. Fixes Qiskit#2417
* Make pylatexenc and pillow optional The pylatexenc and pillow requirements are only used in the latex and latex_source circuit drawers. Since this isn't used by everyone and is a non-default circuit drawer there is no reason we should force our users to install these by default. This commit updates the requirements list and setup.py to make these 2 requirements optional and included in the visualization setuptools extras to ease installation. If the packages are not installed it will raise an ImportError with a detailed exception explaining how to install the missing dependency. Fixes #2417 * Fix lint * Fix lint again
* Make pylatexenc and pillow optional The pylatexenc and pillow requirements are only used in the latex and latex_source circuit drawers. Since this isn't used by everyone and is a non-default circuit drawer there is no reason we should force our users to install these by default. This commit updates the requirements list and setup.py to make these 2 requirements optional and included in the visualization setuptools extras to ease installation. If the packages are not installed it will raise an ImportError with a detailed exception explaining how to install the missing dependency. Fixes Qiskit#2417 * Fix lint * Fix lint again
What is the expected enhancement?
pylatexenc is used in a relatively minor place for formatting latex_drawer's strings. Given that everything associated with latex drawing is optional itself, this part should also be optional and not a core dependency of terra.
The text was updated successfully, but these errors were encountered: