Revert disabling validation of parameter type when binding expression…

… in gate I had disabled this because it uncovered a bug in gates-in-rust. The changes that led to this in gates-in-rust have now been reverted and merged into this branch. So I am re-enabling the test.
Qiskit · Jun 5, 2024 · a13ee16 · a13ee16
1 parent 855ccea
commit a13ee16
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 4 deletions.
diff --git a/crates/circuit/src/operations.rs b/crates/circuit/src/operations.rs
@@ -642,7 +642,7 @@ impl Operation for StandardGate {
                             0,
                             &[(
                                 OperationType::Standard(Self::UGate),
-                                Some(&defparams),
+                                &defparams,
                                 &[0],
                             )],
                             FLOAT_ZERO,

diff --git a/qiskit/circuit/library/standard_gates/r.py b/qiskit/circuit/library/standard_gates/r.py
@@ -59,11 +59,10 @@ def __init__(
         *,
         duration=None,
         unit="dt",
-        _skip_validation=False,
     ):
         """Create new r single-qubit gate."""
         super().__init__("r", 1, [theta, phi], label=label, duration=duration, unit=unit,
-                         _skip_validation=_skip_validation,)
+                         )
 
     def _define(self):
         """

diff --git a/test/python/circuit/test_parameters.py b/test/python/circuit/test_parameters.py
@@ -1641,7 +1641,6 @@ def test_complex_angle_raises_when_not_supported(self):
             ref.r(0, 0, 0)
             self.assertEqual(bound, ref)
 
-        self.skipTest("Temporarily disabled for #12459")
         with self.subTest("binding x to 1 yields complex parameters"):
             # RGate does not support complex parameters
             with self.assertRaises(CircuitError):