Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docstring with missing line #1493

Merged
merged 2 commits into from
Mar 11, 2024
Merged

Conversation

kt474
Copy link
Member

@kt474 kt474 commented Mar 7, 2024

Summary

Details and comments

Fixes #1481

@coveralls
Copy link

coveralls commented Mar 7, 2024

Pull Request Test Coverage Report for Build 8234578870

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall first build on minor-docstring-fix at 82.284%

Totals Coverage Status
Change from base Build 8234553257: 82.3%
Covered Lines: 5764
Relevant Lines: 7005

💛 - Coveralls

@kt474 kt474 merged commit dea880c into Qiskit:main Mar 11, 2024
18 checks passed
@kt474 kt474 deleted the minor-docstring-fix branch March 11, 2024 14:37
@woodsp-ibm
Copy link
Member

woodsp-ibm commented Mar 11, 2024

@kt474 Your fix is this, which refers to backend before its selected/created - shouldn't pm be created after the backend line as I commented in the issue

+    pm = generate_preset_pass_manager(target=backend.target, optimization_level=1)

    backend = service.least_busy(operational=True, simulator=False)

@kt474
Copy link
Member Author

kt474 commented Mar 11, 2024

@kt474 Your fix is this, which refers to backend before its selected/created - shouldn't pm be created after the backend line as I commented in the issue

+    pm = generate_preset_pass_manager(target=backend.target, optimization_level=1)

    backend = service.least_busy(operational=True, simulator=False)

 Sorry you're right, I shouldn't have merged this - i'll fix it now

@kt474 kt474 mentioned this pull request Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

qiskit_ibm_runtime/__init__.py sample code is missing pm being created
3 participants