Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update v2 transpilation options #1373

Merged
merged 2 commits into from
Feb 5, 2024
Merged

Update v2 transpilation options #1373

merged 2 commits into from
Feb 5, 2024

Conversation

jyu00
Copy link
Collaborator

@jyu00 jyu00 commented Feb 2, 2024

Summary

  • Remove initial_layout etc from transpilation options for v2 primitives. This closes Remove various transpilation options for v2 primitives #1333
  • Move optimization_level into transpilation now that we only do light transpilation and don't insert DD by default anymore
  • Set max optimization level to 1
  • Set max resilience level to 2

Details and comments

Fixes #

@jyu00 jyu00 requested review from mberna and kt474 February 2, 2024 22:18
@coveralls
Copy link

coveralls commented Feb 2, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 7787451061

  • -1 of 20 (95.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.03%) to 78.831%
Changes Missing Coverage Covered Lines Changed/Added Lines %
qiskit_ibm_runtime/options/transpilation_options.py 12 13 92.31%
Totals Coverage Status
Change from base Build 7730924890: -0.03%
Covered Lines: 5083
Relevant Lines: 6448
💛 - Coveralls

kt474
kt474 approved these changes Feb 5, 2024
View reviewed changes
@jyu00 @kt474
Update test/unit/test_ibm_primitives_v2.py
59817ba 
Co-authored-by: Kevin Tian <kt474@cornell.edu>
@jyu00 jyu00 merged commit f9bcb47 into Qiskit:experimental-0.2 Feb 5, 2024
17 checks passed
@jyu00 jyu00 deleted the transpiler-options branch February 5, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kt474 kt474 kt474 approved these changes

@mberna mberna Awaiting requested review from mberna

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jyu00 @coveralls @kt474