-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removal of deprecated Qiskit 2.0 related code #2318
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most of the actual removals seem good to me but I'm not sure about deprecations though. I've left line comments asking about deprecation and requests for some documentation fixes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few documentation related comments, following the decision to implicitly rely on BackendProperties
in qiskit-ibm-runtime
.
* Usage of `qiskit.pulse` is removed. | ||
* Use of `BackendProperties` is removed. | ||
* `BackendV1` related code is removed. | ||
* Use of `BackendStatus` was removed, resulting in the removal of the :meth:`status` method for the Aer backend. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* Use of `BackendStatus` was removed, resulting in the removal of the :meth:`status` method for the Aer backend. | |
* Use of `BackendStatus` was removed, resulting in the removal of the `status` method for the Aer backend. |
Remove the parts of the code that relied on deprecated `qiskit` components that are being removed in Qiskit 2.0:: | ||
* Everything that uses `convert_to_target` is removed | ||
* Usage of `qiskit.pulse` is removed. | ||
* Use of `BackendProperties` is removed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* Use of `BackendProperties` is removed. | |
* `BackendProperties` is not being imported from `qiskit.providers.models.backendproperties` anymore. | |
The method :meth:`NoiseModel.from_backend_properties` still assumes a `BackendProperties` object as in | |
`qiskit_ibm_runtime.models.backend_properties` passed through the `properties` argument. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM now, thanks @gadial
Summary
Removes code that is incompatible with the upcoming Qiskit 2.0 release.
Details and comments
Qiskit 2.0 drops support for Pulse and BackendV1, resulting in several required removals:
convert_to_target
is removedqiskit.pulse
is removed.BackendProperties
is removed.BackendV1
related code is removed.BackendStatus
was removed, resulting in the removal of thestatus
method for the Aer backend.