Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removal of deprecated Qiskit 2.0 related code #2318

Merged
merged 10 commits into from
Mar 3, 2025

Conversation

gadial
Copy link
Collaborator

@gadial gadial commented Feb 18, 2025

Summary

Removes code that is incompatible with the upcoming Qiskit 2.0 release.

Details and comments

Qiskit 2.0 drops support for Pulse and BackendV1, resulting in several required removals:

  • Everything that uses convert_to_target is removed
  • Usage of qiskit.pulse is removed.
  • Use of BackendProperties is removed.
  • BackendV1 related code is removed.
  • Use of BackendStatus was removed, resulting in the removal of the status method for the Aer backend.

Copy link
Collaborator

@eliarbel eliarbel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of the actual removals seem good to me but I'm not sure about deprecations though. I've left line comments asking about deprecation and requests for some documentation fixes.

Copy link
Collaborator

@eliarbel eliarbel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few documentation related comments, following the decision to implicitly rely on BackendProperties in qiskit-ibm-runtime.

* Usage of `qiskit.pulse` is removed.
* Use of `BackendProperties` is removed.
* `BackendV1` related code is removed.
* Use of `BackendStatus` was removed, resulting in the removal of the :meth:`status` method for the Aer backend.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Use of `BackendStatus` was removed, resulting in the removal of the :meth:`status` method for the Aer backend.
* Use of `BackendStatus` was removed, resulting in the removal of the `status` method for the Aer backend.

Remove the parts of the code that relied on deprecated `qiskit` components that are being removed in Qiskit 2.0::
* Everything that uses `convert_to_target` is removed
* Usage of `qiskit.pulse` is removed.
* Use of `BackendProperties` is removed.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Use of `BackendProperties` is removed.
* `BackendProperties` is not being imported from `qiskit.providers.models.backendproperties` anymore.
The method :meth:`NoiseModel.from_backend_properties` still assumes a `BackendProperties` object as in
`qiskit_ibm_runtime.models.backend_properties` passed through the `properties` argument.

Copy link
Collaborator

@eliarbel eliarbel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM now, thanks @gadial

@gadial gadial merged commit a260d95 into Qiskit:main Mar 3, 2025
34 checks passed
@gadial gadial deleted the qiskit_2_compatability branch March 3, 2025 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants