Pass CMAKE_GENERATOR_PLATFORM thorugh scikit_build in win32 builds #1143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems that when forcing scikit-build to use Visual Studio 2019 through CMAKE_GENERATOR env var, it is always asumming it is building for 64 bits, even if you are working with Python 32 bits. More over, it doesn't honor the CMAKE_GENERATOR_PLATFORM env variable, so no option to use the proper 32 bits compiler. In this commit we check if we are in a Win 32 bit Python environment and pass CMAKE_GENERATOR_PLATFORM=Win32 directly to CMake.
mtreinish
approved these changes
Feb 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
It seems that when forcing scikit-build to use Visual Studio 2019 through
CMAKE_GENERATORenv var, it is always assuming it is building for 64 bits,even if you are working with
Python32 bits. More over, it doesn't honor theCMAKE_GENERATOR_PLATFORMenv variable, so no option to use the proper 32 bitscompiler. In this commit we check if we are in a
Win32 bitPythonenvironmentand pass
CMAKE_GENERATOR_PLATFORM=Win32directly toCMake.Details and comments