Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Previewing shortcuts to steam/twitch/...-apps launches them while showing an error. #625

Closed
lepathie opened this issue Mar 31, 2020 · 2 comments · Fixed by #643
Closed

Previewing shortcuts to steam/twitch/...-apps launches them while showing an error. #625

lepathie opened this issue Mar 31, 2020 · 2 comments · Fixed by #643

Comments

@lepathie
Copy link
Contributor

lepathie commented Mar 31, 2020 •
edited
Loading

Description
When previewing shortcuts where the URL is like f.e. steam://rungameid/certain_game or twitch://fuel-launch/certain_game, the url gets called and therefore the programs launch. Also the message "Navigation to webpage was canceled" pops up.

To Reproduce
Steps to reproduce the behavior:

  1. Go to location of your steam/twitch/... shortcuts.
  2. Click on a steam/twitch/... shortcut.
  3. Press space / Invoke QuickLook.
  4. See error.

Expected behavior
Show large icon of application/game with name and "open" button in the dialog.

Desktop:

  • OS Version: Windows 10 1909
  • QuickLook Version: 3.6.6.0 from Windows Store

Possible solution
Implement special treatment for all protocols in the url except HTTP/HTTPS/... .

Screenshot
image
@lepathie
Copy link
Contributor Author

lepathie commented Apr 9, 2020

Currently working on a plugin that uses the users standard programs to open the other protocols after user confirm.

lepathie added a commit to lepathie/QuickLook.Plugin.UrlViewer that referenced this issue Apr 9, 2020
@lepathie
Initial Layout
83b98c2 
This commit contains initial layout of the launcher without any further logic yet.

Ref: QL-Win/QuickLook#625
@lepathie
Copy link
Contributor Author

lepathie commented May 2, 2020 •
edited
Loading

I currently don't have enough time to finish that plugin and it propably isn't even that useful because the default window already features an open with-button.

image

Since I already fixed the "bug" in my fork I'll create a pull request for that.

@lepathie lepathie mentioned this issue May 2, 2020
Merged
xupefei added a commit that referenced this issue May 3, 2020
@xupefei
Merge pull request #643 from lepathie/bugfix/#625_unsupported_protoco…
567ed0c 
…ls_open_in_browser

Bugfix for #625: The HtmlViewer opens `.url`s with unsupported protocols in internal browser.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bugfix for #625: The HtmlViewer opens .urls with unsupported protocols in internal browser.
1 participant
@lepathie