Window position issue on the secondary monitor

[tsanie]

Describe the bug
When I switch the files on the secondary monitor, the QuickLook window doesn't keep a well position.
There is no problem in the primary monitor.
And it is different with #260

To Reproduce
Steps to reproduce the behavior:

1. Select a file in the secondary monitor
2. Press the Space button
3. Then press the ↓ button to switch to another file
4. Now the QuickLook window move to the center of the two monitors (and be separated)

Expected behavior
The QuickLook window stays in the current monitor.

Desktop (please complete the following information):

• OS Version: Windows 10 1809 (OS Build 17763.195)
• QuickLook Version: 3.6.4 from the released .msi

Screenshots and Exception Log

[xupefei]

Can you try this version: https://ci.appveyor.com/project/xupefei/quicklook/builds/19487008/artifacts
Is there any difference?

[tsanie]

I can't reproduce the problem in my work computer, which also have two monitor. 😭 The two versions (3.6.2-27-g6768f44 and 3.6.4) both looks well.

I'll try this version after work later.

[tsanie]

@xupefei Yes, the 3.6.2 version would keep the right position in the secondary monitor.
But another problem appeared, the window text in the secondary monitor looks blur. (The zoom scale in the primary monitor is 125%, and the secondary monitor is 100%.)

[xupefei]

There are some known issues with DPI scaling now, see #420.
In short, we have to choose either (i) correct window position and blurry UI on one of the screens or (ii) incorrect window position and clear UI on all screens.
Blame Microsoft for this.

I prefer to choose (i) which means to revert the DPI-related changes for now. Could you give any comment, @Verrickt?

[Verrickt]

I'd prefer (i) so let's revert the changes and blame Microsoft

[tsanie]

OK, I see.
And is there a solution like: When the QuickLook window be opened in the secondary screen, it shows clearly in the secondary screen. And the primary screen is the same? (if don't consider about move the window to the other screen)

[xupefei]

After reverting changes, the window will be clear on your primary display, i.e., the one showing all desktop icons. When the window shows on your secondary screen, it (always) becomes blurry -- unless two screens have the same DPI scaling factor.

[xupefei]

I noticed that NET framework 4.8 finally adds mixed DPI support: https://docs.microsoft.com/en-us/dotnet/framework/whats-new/index#wpf48

Any volunteer with a multiple-monitor setup?

[renecum]

I have a multiple-monitor setup, I was unable to reproduce the problem.

[CodyPredy]

Same problem on a multi desktop setup.
Primary - 4K, Secondary - 1080p.
Secondary is shifted bottom aligned with the primary. On initial preview it's completely centered. Shifting to other files using bottom or top arrow keys shifts the position of the preview pane.

[xupefei]

Yes, the problem happens when monitors are in different DPI.

[xupefei]

This is issue should be fixed in https://ci.appveyor.com/project/xupefei/quicklook/builds/35688242/artifacts. Could you try?

[tsanie]

This is issue should be fixed in https://ci.appveyor.com/project/xupefei/quicklook/builds/35688242/artifacts. Could you try?

It seems correct through the Team viewer. I will try it on the local side in the evening, now here is only macOS.

[tsanie]

@xupefei There is no position issues any more, but the quick look is too large in the main monitor now. (correct in the secondary monitor)

1 display: 2560x1440, dpi 125%
2 display: 1080x1920, dpi 100%

[xupefei]

The second issue should have been fixed in https://ci.appveyor.com/project/xupefei/quicklook/builds/35688332/artifacts.

Nice pic BTW :)

[tsanie]

The second issue should have been fixed in https://ci.appveyor.com/project/xupefei/quicklook/builds/35688332/artifacts.

Nice pic BTW :)

Resolved, perfect 👍