Video Preview not working

[artikweb]

Hello,
I installed the new release (v 0.3.2) today and there's a major bug affecting video previewing.
I installed the .msi package on a Windows 10 v. 1709 (Fall Creators Update) x64 and it's not possible at all to preview any video file. I tried previewing a .mp4 (h264) video file as well as a .mkv to no avail. Nothing happens, not even an error message.
When trying so preview any other file after trying to preview a video, Quicklook also does not respond, I had to force close the app process through task manager because the icon on the system tray also stops working.

Should you need any more information (or help reproducing this bug), contact me asap and I'll be glad to help.

[xupefei]

Go to install_folder\Plugins\VideoViewer\FFmpeg folder. There should have a ffprobe.exe file. Can you run it in the command prompt?

[artikweb]

Yes, here's the output:

[xupefei]

Strange. How about FFprobe.exe "<any_video_file>"?

[artikweb]

[xupefei]

Seems the probe is working normally.
Can you debug the project by setting a breakpoint here:https://github.com/xupefei/QuickLook/blob/master/QuickLook.Plugin/QuickLook.Plugin.VideoViewer/Plugin.cs#L72
Does the program hang here?

[artikweb]

I don't have the project configured on this machine, I'll have to set it up (might take a while since VS isn't updated). I'll post the results here ASAP.

[xupefei]

It may takes some time since I have updated the Windows SDK recently.
Can you alternatively provide me a sample video file so i can have a try?

[artikweb]

Just sent you an email with a link. 😉

[xupefei]

Thanks for your link. Your video plays correctly on my machine.
If the Big Buck Bunny works for you, then it may be related to the HW acceleration.
I have made a new plugin w/o it. Could you try it?

QuickLook.Plugin.VideoViewer.zip

[artikweb]

I'm having trouble trying to compile QL. I'm always getting this git-related error. Do you know how can I fix this? (Already have git installed and the commands inside the powershell file execute fine)

[xupefei]

You should enable local execution of powershell scripts. The command is here: https://superuser.com/questions/106360/how-to-enable-execution-of-powershell-scripts <https://superuser.com/questions/106360/how-to-enable-execution-of-powershell-scripts> cheers, Paddy

…

On 6 Nov 2017, at 14:48, Emanuel Alves ***@***.***> wrote: I'm having trouble trying to compile QL. I'm always getting this git-related error. Do you know how can I fix this? (Already have git installed) <https://user-images.githubusercontent.com/6955982/32441751-cedc2b28-c2f0-11e7-8b56-d2929fd19b29.png> — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#113 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABnBJ-4pIzyTxnM9GuX1abyhUIKHONJzks5szwAqgaJpZM4QTHrG>.

[artikweb]

Thanks.
Here's the info on the breakpoint. I also tried using the updated VideoViewer you sent, didn't work.
As you see in the screeshot below, I set two breakpoints, however, the second one is never reached. Execution goes into new FFProbe after I click "Continue" and never runs the probe.HasVideo().

[xupefei]

Thanks for helping locate the problem!
Could you move into the FFprobe class, and test if this line is reached: https://github.com/xupefei/QuickLook/blob/master/QuickLook.Plugin/QuickLook.Plugin.VideoViewer/ffmpeg/FFprobe.cs#L54

1. If no, can you execute ffprobe.exe -v quiet -print_format xml -show_streams -show_format "<something.mkv>" in command prompt?

2. If (1) successes, try comment out this line p.StartInfo.StandardOutputEncoding = Encoding.UTF8; and debug again.

[artikweb]

Execution (on FFprobe) hits the breakpoint, however, commenting p.StartInfo.StandardOutputEncoding = Encoding.UTF8; doesn't change the behaviour. Nothing still happens.

Executing the FFprobe command results in an empty XML file.

I also added a breakpoint after line 56 (result = p.StandardOutput.ReadToEnd();) and execution never hits it.

[xupefei]

How about the next line? Does line 56 or 59 be reached?

[xupefei]

Okay, I think I have figured out the problem.
Could you try swap Line 54 and 56, i.e.,

result = p.StandardOutput.ReadToEnd();
p.WaitForExit();

[artikweb]

Yep, that did the trick. It's working fine now :)

[xupefei]

Thanks for the feedback! I will fix it now.

[artikweb]

You're welcome! Glad I could help :)