Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor AssetSupply to AssetRecords and update issuance verification functions #138

Merged
merged 30 commits into from
Feb 4, 2025
Merged

Refactor AssetSupply to AssetRecords and update issuance verification functions #138

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
2c93e40
Modify verify_issue_bundle function to use get_asset_state instead of…
dmidem Jan 21, 2025
29baa1a
Merge branch 'zsa1' into verif-for-zebra-1
dmidem Jan 27, 2025
c54d448
Rename IssueAction::verify_supply to IssueAction::verify
dmidem Jan 27, 2025
9739253
Simplify Error variant imports by referencing the local Error enum di…
dmidem Jan 27, 2025
6f7ba6d
Introduce AssetInfo generic and use it instead of AssetSupply struct,…
dmidem Jan 27, 2025
48abd86
Remove FIXME
dmidem Jan 27, 2025
fb0326a
Make AssetInfo a regular struct instead of generic, use it for bundle…
dmidem Jan 28, 2025
acbb6b2
Add FIXME comment
dmidem Jan 28, 2025
4dce9d5
Update FIXME comments
dmidem Jan 28, 2025
1fe7057
get_finalization_set test helper function removed, issue bundle verif…
dmidem Jan 29, 2025
991368b
Add an issuance workflow test (issue_bundle_verify_with_global_state)
dmidem Jan 29, 2025
3328fe6
Merge branch 'zsa1' into verif-for-zebra-1
dmidem Jan 29, 2025
9016d18
Add a case for ValueOverflow error to the issuance workflow test
dmidem Jan 29, 2025
888022b
Update comments and remove asset from IssueActionPreviouslyFinalizedA…
dmidem Jan 30, 2025
5a30c2f
Refactor verify_issue_bundle according to #138 PR review
dmidem Jan 30, 2025
f87de8e
Simplify verify_issue_bundle's return
dmidem Jan 30, 2025
422e2fc
Make build_issue_bundle (in issuance.rs issue_bundle_verify_with_glob…
dmidem Jan 30, 2025
9ecbeea
Add updated supply_info.rs
dmidem Jan 30, 2025
81d7d09
is_asset_desc_of_valid_size check moved from verify_issue_bundle to I…
dmidem Jan 30, 2025
a8152fd
Rename supply_info.rs to asset_record.rs
dmidem Jan 30, 2025
09149a0
Minor: add new line
dmidem Jan 30, 2025
4c7d484
Minor code format fixes (empty line, comment)
dmidem Jan 31, 2025
956e1d0
Introduce TestParams struct in the test part of issuance.rs and use i…
dmidem Jan 31, 2025
322a55a
Moved issue_bundle_verify_with_global_state into a separate file and …
dmidem Jan 31, 2025
c8208d1
Remove revert_issue_bundle function
dmidem Feb 3, 2025
df9d5eb
Rename BundleTestData to IssueTestNote
dmidem Feb 3, 2025
fce03d5
Move issuance/tests/global_state.rs to the integration_tests folder a…
dmidem Feb 3, 2025
3b03580
Update setup_params in issuance_global_state.rs to not use orchard pu…
dmidem Feb 4, 2025
f83e6ea
Use another way to get a random Nullifier for testing in issuance_glo…
dmidem Feb 4, 2025
409bdf5
Improve comments inissuance_global_state.rs::setup_params
dmidem Feb 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading
Loading