Rename V2 name suffixes to Vanilla, and V3 - to ZSA #625
dmidem
This run and associated checks have been archived and are scheduled for deletion.
Learn more about checks retention
Annotations
23 warnings
|
usage of `Iterator::fold` on a type that implements `Try`:
src/value.rs#L232
warning: usage of `Iterator::fold` on a type that implements `Try`
--> src/value.rs:232:14
|
232 | iter.fold(Ok(ValueSum(0)), |acc, v| (acc? + v).ok_or(OverflowError))
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `try_fold` instead: `try_fold(ValueSum(0), |acc, v| ...)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_try_fold
|
|
usage of `Iterator::fold` on a type that implements `Try`:
src/value.rs#L226
warning: usage of `Iterator::fold` on a type that implements `Try`
--> src/value.rs:226:14
|
226 | iter.fold(Ok(ValueSum(0)), |acc, v| (acc? + *v).ok_or(OverflowError))
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `try_fold` instead: `try_fold(ValueSum(0), |acc, v| ...)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_try_fold
|
|
use of a fallible conversion when an infallible one could be used:
src/note_encryption.rs#L448
warning: use of a fallible conversion when an infallible one could be used
--> src/note_encryption.rs:448:14
|
448 | .try_into()
| ______________^
449 | | .unwrap()
| |_____________________^ help: use: `into()`
|
= note: converting `&[u8]` to `<D as OrchardDomain>::CompactNoteCiphertextBytes` cannot fail
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fallible_conversions
|
|
explicit call to `.into_iter()` in function argument accepting `IntoIterator`:
src/note_encryption.rs#L424
warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
--> src/note_encryption.rs:424:18
|
424 | .zip(ephemeral_keys.into_iter())
| ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `ephemeral_keys`
|
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
--> /rustc/e8b6db72515807fa301ff8d39b8ac058d5653fd1/library/core/src/iter/traits/iterator.rs:643:12
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
= note: `#[warn(clippy::useless_conversion)]` on by default
|
|
use of a fallible conversion when an infallible one could be used:
src/note_encryption.rs#L404
warning: use of a fallible conversion when an infallible one could be used
--> src/note_encryption.rs:404:18
|
404 | (compact.try_into().unwrap(), memo.try_into().unwrap())
| ^^^^^^^^^^^^^^^^^^^ help: use: `into()`
|
= note: converting `&[u8]` to `<D as OrchardDomain>::CompactNotePlaintextBytes` cannot fail
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fallible_conversions
= note: `#[warn(clippy::unnecessary_fallible_conversions)]` on by default
|
|
use of `default` to create a unit struct:
src/note/commitment.rs#L164
warning: use of `default` to create a unit struct
--> src/note/commitment.rs:164:31
|
164 | let mut os_rng = OsRng::default();
| ^^^^^^^^^^^ help: remove this call to `default`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs
= note: `#[warn(clippy::default_constructed_unit_structs)]` on by default
|
|
accessing first element with `notes.get(0)`:
tests/zsa.rs#L171
warning: accessing first element with `notes.get(0)`
--> tests/zsa.rs:171:17
|
171 | let note1 = notes.get(0).unwrap();
| ^^^^^^^^^^^^ help: try: `notes.first()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first
= note: `#[warn(clippy::get_first)]` on by default
|
|
usage of `Iterator::fold` on a type that implements `Try`:
src/value.rs#L232
warning: usage of `Iterator::fold` on a type that implements `Try`
--> src/value.rs:232:14
|
232 | iter.fold(Ok(ValueSum(0)), |acc, v| (acc? + v).ok_or(OverflowError))
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `try_fold` instead: `try_fold(ValueSum(0), |acc, v| ...)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_try_fold
|
|
usage of `Iterator::fold` on a type that implements `Try`:
src/value.rs#L226
warning: usage of `Iterator::fold` on a type that implements `Try`
--> src/value.rs:226:14
|
226 | iter.fold(Ok(ValueSum(0)), |acc, v| (acc? + *v).ok_or(OverflowError))
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `try_fold` instead: `try_fold(ValueSum(0), |acc, v| ...)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_try_fold
|
|
use of a fallible conversion when an infallible one could be used:
src/note_encryption.rs#L448
warning: use of a fallible conversion when an infallible one could be used
--> src/note_encryption.rs:448:14
|
448 | .try_into()
| ______________^
449 | | .unwrap()
| |_____________________^ help: use: `into()`
|
= note: converting `&[u8]` to `<D as OrchardDomain>::CompactNoteCiphertextBytes` cannot fail
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fallible_conversions
|
|
explicit call to `.into_iter()` in function argument accepting `IntoIterator`:
src/note_encryption.rs#L424
warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator`
--> src/note_encryption.rs:424:18
|
424 | .zip(ephemeral_keys.into_iter())
| ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `ephemeral_keys`
|
note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()`
--> /rustc/e8b6db72515807fa301ff8d39b8ac058d5653fd1/library/core/src/iter/traits/iterator.rs:643:12
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
= note: `#[warn(clippy::useless_conversion)]` on by default
|
|
use of a fallible conversion when an infallible one could be used:
src/note_encryption.rs#L404
warning: use of a fallible conversion when an infallible one could be used
--> src/note_encryption.rs:404:18
|
404 | (compact.try_into().unwrap(), memo.try_into().unwrap())
| ^^^^^^^^^^^^^^^^^^^ help: use: `into()`
|
= note: converting `&[u8]` to `<D as OrchardDomain>::CompactNotePlaintextBytes` cannot fail
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fallible_conversions
= note: `#[warn(clippy::unnecessary_fallible_conversions)]` on by default
|
|
usage of `Iterator::fold` on a type that implements `Try`:
src/builder.rs#L538
warning: usage of `Iterator::fold` on a type that implements `Try`
--> src/builder.rs:538:14
|
538 | .fold(Some(ValueSum::zero()), |acc, action| {
| ______________^
539 | | acc? + action.value_sum()
540 | | })
| |______________^ help: use `try_fold` instead: `try_fold(ValueSum::zero(), |acc, action| ...)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_try_fold
|
|
usage of `Iterator::fold` on a type that implements `Try`:
src/builder.rs#L461
warning: usage of `Iterator::fold` on a type that implements `Try`
--> src/builder.rs:461:14
|
461 | .fold(Some(ValueSum::zero()), |acc, note_value| acc? + note_value)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `try_fold` instead: `try_fold(ValueSum::zero(), |acc, note_value| ...)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_try_fold
= note: `#[warn(clippy::manual_try_fold)]` on by default
|
|
usage of `Iterator::fold` on a type that implements `Try`:
src/builder.rs#L538
warning: usage of `Iterator::fold` on a type that implements `Try`
--> src/builder.rs:538:14
|
538 | .fold(Some(ValueSum::zero()), |acc, action| {
| ______________^
539 | | acc? + action.value_sum()
540 | | })
| |______________^ help: use `try_fold` instead: `try_fold(ValueSum::zero(), |acc, action| ...)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_try_fold
|
|
usage of `Iterator::fold` on a type that implements `Try`:
src/builder.rs#L461
warning: usage of `Iterator::fold` on a type that implements `Try`
--> src/builder.rs:461:14
|
461 | .fold(Some(ValueSum::zero()), |acc, note_value| acc? + note_value)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `try_fold` instead: `try_fold(ValueSum::zero(), |acc, note_value| ...)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_try_fold
= note: `#[warn(clippy::manual_try_fold)]` on by default
|
|
unused imports: `H`, `ValueCommitV`:
src/constants.rs#L6
warning: unused imports: `H`, `ValueCommitV`
--> src/constants.rs:6:77
|
6 | pub use fixed_bases::{NullifierK, OrchardFixedBases, OrchardFixedBasesFull, ValueCommitV, H};
| ^^^^^^^^^^^^ ^
|
= note: `#[warn(unused_imports)]` on by default
|
|
unused imports: `H`, `ValueCommitV`:
src/constants.rs#L6
warning: unused imports: `H`, `ValueCommitV`
--> src/constants.rs:6:77
|
6 | pub use fixed_bases::{NullifierK, OrchardFixedBases, OrchardFixedBasesFull, ValueCommitV, H};
| ^^^^^^^^^^^^ ^
|
= note: `#[warn(unused_imports)]` on by default
|
|
Clippy (beta)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions-rs/toolchain@v1, actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
Clippy (beta)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Clippy (beta)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Clippy (beta)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Clippy (beta)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|