Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update warn_deprecation to get deprecated and removal versions #1028

Merged
merged 3 commits into from
Dec 13, 2024

Conversation

bact
Copy link
Member

@bact bact commented Dec 13, 2024

warn_deprecation() function will now get two version arguments: one for deprecated version, another for removal version.

@bact bact added the enhancement enhance functionalities label Dec 13, 2024
@bact bact added this to the 5.0 milestone Dec 13, 2024
@pep8speaks
Copy link

pep8speaks commented Dec 13, 2024

Hello @bact! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 22:101: E501 line too long (105 > 100 characters)

Comment last updated at 2024-12-13 12:55:06 UTC

@coveralls
Copy link

coveralls commented Dec 13, 2024

Coverage Status

coverage: 52.847% (-0.01%) from 52.86%
when pulling 40a2c67 on bact:dev
into 2287b30 on PyThaiNLP:dev.

@bact bact modified the milestones: 5.0, 5.1 Dec 13, 2024
@bact bact merged commit 2ab64f6 into PyThaiNLP:dev Dec 13, 2024
23 of 25 checks passed
This was referenced Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement enhance functionalities
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants