Use uv for installing dependencies in CI on Linux-only workflows #466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
|
Hmm, not as much of a speedup as I was hoping for, really. Still pretty slow to install dependencies on Windows :/ Not really sure if this is worth the extra complexity for us right now, but interested to hear other people's opinions. |
|
It it's not a considerable speedup, I'd keep pip for now. Maybe at some point there will be an easier way to install |
|
There's still pretty impressive speedups (and not nearly the same added complexity) for the jobs that don't run on Windows. I'll merge just those change for now. |
AlexWaygood
changed the title
|
This change has no effect on typeshed. 🤖🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's currently taking 24s to install dependencies on Windows in CI, and only 7s to actually run the tests when the dependencies have been installed.
Also, bump a few Python versions in our workflow files, while we're at it.