Merge pull request #266 from caarlos0/issuer-key-id

Make Issuer Key ID signature subpacket non-critical
ProtonMail · Feb 27, 2025 · d47bb38 · d47bb38
2 parents 44ef98c + 756ebbd
commit d47bb38
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/openpgp/packet/signature.go b/openpgp/packet/signature.go
@@ -1288,7 +1288,9 @@ func (sig *Signature) buildSubpackets(issuer PublicKey) (subpackets []outputSubp
 	if sig.IssuerKeyId != nil && sig.Version == 4 {
 		keyId := make([]byte, 8)
 		binary.BigEndian.PutUint64(keyId, *sig.IssuerKeyId)
-		subpackets = append(subpackets, outputSubpacket{true, issuerSubpacket, true, keyId})
+		// Note: making this critical breaks RPM <=4.16.
+		// See: https://github.com/ProtonMail/go-crypto/issues/263
+		subpackets = append(subpackets, outputSubpacket{true, issuerSubpacket, false, keyId})
 	}
 	// Notation Data
 	for _, notation := range sig.Notations {