Preserve viewport maybe #4117
Draft
Preserve viewport maybe #4117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barmintor
reviewed
Feb 28, 2025
| } | ||
| } | ||
|
|
||
| }, [osdConfig, viewerConfig, worldBounds, viewerRef]); |
There was a problem hiding this comment.
if worldBounds is an array, I think this effect is always going to run because the object reference will change. I think the approach is sound, but we'd need to unroll the array into integers, right?
cbeer
force-pushed
the
preserve-viewport-maybe
branch
from
26b47fd to
97e3fe7
Compare
cbeer
force-pushed
the
preserve-viewport-maybe
branch
from
97e3fe7 to
fc3ce9a
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4117 +/- ##
==========================================
- Coverage 94.80% 94.76% -0.04%
==========================================
Files 323 323
Lines 16158 16188 +30
Branches 2538 2546 +8
==========================================
+ Hits 15318 15340 +22
- Misses 835 843 +8
Partials 5 5 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.