-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support directly mmap-ing datafiles #5242
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e450336
to
89add11
Compare
daniel-j-h
reviewed
Oct 23, 2018
5065ac0
to
f0c72cc
Compare
…ut for vector_view<bool> so that data can be directly mmapped.
… data into separate mmapped block Co-authored-by: Kajari Ghosh <ghoshkaj@gmail.com>
…est suite in this mode, as well as shared memory mode.
f0c72cc
to
b7e7d32
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
This PR completes the vision initially described in #1947. It builds on the work done by @TheMarex in #4881
Turns out, #4881 was almost there, it really only required the following changes:
vector_view<bool>
,.fileIndex
Fortunately,
.tar
files are block aligned on 512 byte boundaries - this conveniently means the data is properly word aligned if we directlymmap
the entire.tar
file.There is no change here to the pre-processing tooling. However,
osrm-routed
(and the NodeJS bindings), now support the--mmap
(ormmap_memory: true
for NodeJS) options. When triggered, instead of loading all data into RAM, this causes OSRM to directlymmap
datafiles.This means you can run OSRM in quite constrained memory environments, if you're willing to sacrifice performance. Supplying sufficient memory to allow page caching to have effect means that if your data has some common access patterns, you can achieve quite good performance with significantly less runtime RAM. Realistic benchmarking for your particular scenario is necessary to decide how much RAM will give you acceptible performance, but at least now this knob exists to tune.
Tasklist