Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated segregated intersection identification #4845

Merged
merged 16 commits into from
Feb 27, 2018
Merged

Updated segregated intersection identification #4845

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
c74205e
Initial internal intersection updates
dgearhart Jan 28, 2018
7400b22
Added Internal Intersection Model
dgearhart Feb 1, 2018
bc309ef
removed debug info
dgearhart Feb 1, 2018
eae9660
updates per PR 4845
kdiluca Feb 5, 2018
d833e9d
fixing build errors
kdiluca Feb 6, 2018
2028b3e
fixing all compile errors
kdiluca Feb 6, 2018
1fac1dc
fixed EdgeID param
dgearhart Feb 6, 2018
8a2fae5
Added is_internal_straight lambda
dgearhart Feb 6, 2018
641628e
added rejection case turn degree logic
kdiluca Feb 22, 2018
1faa918
debug logging
kdiluca Feb 22, 2018
47ef208
added turn angle logic to reject if there are incoming edges that hav…
kdiluca Feb 23, 2018
6de4f4c
fixed formatting
kdiluca Feb 23, 2018
921702a
fix to decrease tile size based on latest turn angle internal interse…
kdiluca Feb 23, 2018
298bf1f
Removed breaks
kdiluca Feb 23, 2018
4ef649a
Update segregated_intersection_classification.cpp
kdiluca Feb 23, 2018
3175d1b
Update CHANGELOG.md
kdiluca Feb 27, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@
- `osrm-routed` accepts a new property `--memory_file` to store memory in a file on disk.
- NodeJS:
- `OSRM` object accepts a new option `memory_file` that stores the memory in a file on disk.
- Internals
- CHANGED #4845: Updated segregated intersection identification


# 5.16.0
Expand Down
46 changes: 46 additions & 0 deletions features/guidance/internal-intersections.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,46 @@
@guidance
Feature: Internal Intersection Model

Background:
Given the profile "car"
Given a grid size of 10 meters

Scenario: Dual-carriage way intersection
Given the node map
"""
a b
| |
c--d--e--f
| |
g--h--i--j
| |
k l
"""

And the ways
| nodes | oneway | name |
| adhk | yes | Broken Land Parkway |
| lieb | yes | Broken Land Parkway |
| fed | yes | Snowden River Parkway |
| dc | yes | Patuxent Woods Drive |
| gh | yes | Patuxent Woods Drive |
| hij | yes | Snowden River Parkway |

When I route I should get
| waypoints | route | turns | # |
| a,k | Broken Land Parkway,Broken Land Parkway | depart,arrive ||
| l,b | Broken Land Parkway,Broken Land Parkway | depart,arrive ||
# | g,j | Patuxent Woods Drive,Snowden River Parkway,Snowden River Parkway | depart,continue,arrive | did not work as expected - might be another issue to handle in post process? |
# | f,c | Snowden River Parkway,Patuxent Woods Drive,Patuxent Woods Drive | depart,continue,arrive | did not work as expected - might be another issue to handle in post process? |
| a,c | Broken Land Parkway,Patuxent Woods Drive,Patuxent Woods Drive | depart,turn right,arrive ||
| g,k | Patuxent Woods Drive,Broken Land Parkway,Broken Land Parkway | depart,turn right,arrive ||
| l,j | Broken Land Parkway,Snowden River Parkway,Snowden River Parkway | depart,turn right,arrive ||
| f,b | Snowden River Parkway,Broken Land Parkway,Broken Land Parkway | depart,turn right,arrive ||
| a,j | Broken Land Parkway,Snowden River Parkway,Snowden River Parkway | depart,turn left,arrive ||
| g,b | Patuxent Woods Drive,Broken Land Parkway,Broken Land Parkway | depart,turn left,arrive ||
| l,c | Broken Land Parkway,Patuxent Woods Drive,Patuxent Woods Drive | depart,turn left,arrive ||
| f,k | Snowden River Parkway,Broken Land Parkway,Broken Land Parkway | depart,turn left,arrive ||
| a,b | Broken Land Parkway,Broken Land Parkway,Broken Land Parkway | depart,continue uturn,arrive ||
| g,c | Patuxent Woods Drive,Patuxent Woods Drive,Patuxent Woods Drive | depart,continue uturn,arrive ||
| l,k | Broken Land Parkway,Broken Land Parkway,Broken Land Parkway | depart,continue uturn,arrive ||
| f,j | Snowden River Parkway,Snowden River Parkway,Snowden River Parkway | depart,continue uturn,arrive ||
Loading