NodeJS version of osrm-routed #4604
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
good idea, i think many people miss this part of the tool chain |
daniel-j-h
reviewed
Oct 13, 2017
| | route/v1/driving/1,1;1 | 400 | Coordinates must be an array of (lon/lat) pairs | | ||
| | route/v1/driving/1,1;1,1,1 | 400 | Coordinates must be an array of (lon/lat) pairs | | ||
| | route/v1/driving/1,1;x | 400 | Coordinates must be an array of (lon/lat) pairs | | ||
| | route/v1/driving/1,1;x,y | 400 | Lng/Lat coordinates must be valid numbers | |
| @@ -47,7 +47,7 @@ class OSRMBaseLoader{ | |||
| if (err) { | |||
| if (retryCount < 10) { | |||
| retryCount++; | |||
| setTimeout(() => { tryConnect(this.scope.OSRM_PORT, retry); }, 10); | |||
| setTimeout(() => { tryConnect(this.scope.OSRM_PORT, retry); }, 100); | |||
There was a problem hiding this comment.
Why the change here? Is 10s no longer enough?
| @@ -96,6 +96,7 @@ Feature: Basic trip planning | |||
| | waypoints | source | trips | | |||
| | a,b,c,d,e,f,g,h,i,j,k,l | first | alkjihgfedcba | | |||
|
|
|||
| @todo | |||
| std::strcpy(buffer.get(), code); | ||
| std::strcat(buffer.get(), ": "); | ||
| std::strcat(buffer.get(), message); | ||
| throw std::logic_error(buffer.get()); |
There was a problem hiding this comment.
Please change the last couple of lines to
const auto code = .. .value;
const auto message = .. .value;
// both are of type std::string now, see https://github.com/Project-OSRM/osrm-backend/blob/031ce72db1bdb724527096703c55741a7c7f572c/include/util/json_container.hpp#L81
throw std::logic_error{code + ": " + message}| } | ||
| else | ||
| { | ||
| throw std::logic_error(code_iter->second.get<osrm::json::String>().value.c_str()); |
There was a problem hiding this comment.
logic_error should have a ctor taking a std::string; the c_str is not needed here
danpat
force-pushed
the
osrm-routed.js
branch
from
a986a33 to
9e690c9
Compare
This was referenced Oct 28, 2017
Closed
ghoshkaj
force-pushed
the
osrm-routed.js
branch
from
39e0823 to
ea27e31
Compare
5 tasks
|
Not really a big priority anymore given that docker kind of won. Also turns out going through the V8 serialization layer is not for free, so the C++ based HTTP server is actually quite a bit faster. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
This PR implements an experimental port of
osrm-routedto NodeJS usingexpressas the URL router.Currently a WIP - all tests pass, but a few error messages have changed, and working on it has shown that our error scenario coverage is not really very complete.
source=last, which according to our docs, is not validosrm-routedcommand-line options and generate help messageTasklist