Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds documentations on 'approaches' parameter. #4104

Merged
merged 1 commit into from
May 31, 2017
Merged

Adds documentations on 'approaches' parameter. #4104

merged 1 commit into from
May 31, 2017

Conversation

fijemax
Copy link
Contributor

@fijemax fijemax commented May 30, 2017 •
edited
Loading

Adds documentations on 'approaches' parameter.

Issue

#2201

PR

#4039

@fijemax fijemax mentioned this pull request May 30, 2017
Merged
5 tasks
daniel-j-h
daniel-j-h reviewed May 30, 2017
View reviewed changes
Copy link
Member

@daniel-j-h daniel-j-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to add a note or warning about the profile's left/right-hand-side driving? Technically it's a limitation on our side but the behavior will not be correct planet wide e.g. on the demo server if we use the default car profile.

CHANGELOG.md Outdated
- new parameter `approaches` for `route`, `table`, 'trip' and `nearest` requests. This parameter keep waypoints on the curb side
(depending 'left_hand_driving' parameter into lua script). 'approaches' accepts both 'curb' and 'unrestricted' values.
- NodeJs Bindings
- new parameter `approaches` for `route`, `table`, 'trip' and `nearest` requests.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you use ` backticks for all highlighting here and above

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Adds documentations on 'approaches' parameter.
e4de307 
Adds changelog
Adds doc/http.md doc
Adds doc/nodejs/api.md doc

Signed-off-by: FILLAU Jean-Maxime <jean-maxime.fillau@mapotempo.com>
@fijemax fijemax force-pushed the mt-approach-doc branch from 357debb to e4de307 Compare May 30, 2017 16:01
@fijemax
Copy link
Contributor Author

fijemax commented May 30, 2017

I added a note to explain that.

@daniel-j-h
Copy link
Member

Perfect thank you!

(Travis test failing is unrelated, see #4110)

@TheMarex TheMarex merged commit 43ddc63 into Project-OSRM:master May 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniel-j-h daniel-j-h daniel-j-h left review comments

Assignees
No one assigned
Labels
Ready To Merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fijemax @daniel-j-h @TheMarex