Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Road Priorities: Stop Signs, Give Ways #3009

Closed
wants to merge 4 commits into from
Closed

Conversation

daniel-j-h
Copy link
Member

@daniel-j-h daniel-j-h commented Oct 5, 2016

For #2652 and #3003.

The goal is to pick up stop signs and give ways from the data in the profiles, determine the way direction the node tags apply to, pass it through the pipeline and eventually influence turn penalties.

Already opening here so we can discuss. WIP.

After double checking the tagging schemes, relation-based tagging is not really an option:

Tasklist

  • detect a way's direction by checking distance to next intersection
  • stop signs: tags on intersection node vs tags on node approaching intersection
  • priority_road tags skip these first two steps; attach to edges directly
  • influence turn penalty
  • add regression / cucumber cases (see docs/testing.md)
  • review
  • adjust for for comments

@daniel-j-h daniel-j-h added this to the 5.5.0 milestone Oct 5, 2016
@daniel-j-h daniel-j-h self-assigned this Oct 5, 2016
@daniel-j-h daniel-j-h force-pushed the road-priorities branch 8 times, most recently from e580979 to 152da9f Compare October 10, 2016 11:13
@daniel-j-h daniel-j-h force-pushed the road-priorities branch 2 times, most recently from 4d8b34c to 8efba17 Compare October 14, 2016 13:09
@daniel-j-h
Copy link
Member Author

Plan for handling arbitrary node penalties is in #3021 (comment) - I rebased this onto master and ripped out the WIP stop sign / give way sign work. @MoKob want to have a look and incorporate this into your turn function work already?

@daniel-j-h daniel-j-h modified the milestones: 5.6.0, 5.5.0 Nov 16, 2016
@TheMarex TheMarex modified the milestones: 5.7.0, 5.6.0 Feb 7, 2017
@daniel-j-h
Copy link
Member Author

This was de-prioritized. It's is blocked / goes hand in hand with #2912.
Not considering it for the 5.7 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants