-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auto-detect Lua compatible with installed Luabind #1185
Conversation
2dcf4a2
to
801d060
Compare
Previous variant was finding Lua 2 times, re-pushed. New logic: if detected Lua does not work, try Lua 5.1 once more. |
Just tried on virtual FreeBSD10 (Clang 3.3, Lua 5.1+Lua 5.2+Luabind 0.9.1 for Lua 5.1). Current develop build fails (luabind uses 5.1, not 5.2 in includes). This branch detects that 5.2 is not suitable for luabind and compiles successfully with 5.1 version:
|
801d060
to
aa5568f
Compare
(seems to work, rebased to develop) |
A couple of seconds are totally fine. |
@alex85k Any updates here? |
Oh, I missed the Appveyor tests failures (thought it works already) on Release build. Will try to check this evening. |
Cool, looking forward! |
aa5568f
to
5a690da
Compare
It was always compiling test sources with Debug configuration.
will help :) |
5a690da
to
cdb8189
Compare
cdb8189
to
f14c6e6
Compare
(re-pushed after fixing variable names) |
Seems to work this time. |
Great. I'll work on getting this merged today. |
Thanks again, great work! |
I tried to implement auto-detecting of compatible Lua like from #1179 using cmake. This PR is mainly for checking on Travis&Appveyor, then maybe it can be included in some form to support problematic multi-Lua systems.