Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI #22

Merged
merged 2 commits into from
Feb 24, 2025
Merged

Update CI #22

merged 2 commits into from
Feb 24, 2025

Conversation

malberts
Copy link
Contributor

@malberts malberts commented Feb 24, 2025

Summary by CodeRabbit

  • Chores
    • Improved automated testing by introducing enhanced error tolerance for experimental test runs.
    • Updated the PHP version for the main branch testing to align with the latest environment requirements.
    • Updated platform requirements in the documentation to reflect support for PHP 8.3 and MediaWiki 1.43.

Copy link

coderabbitai bot commented Feb 24, 2025

📝 Walkthrough

Walkthrough

The changes modify the CI configuration by updating the test job in the workflow file. A new parameter, experimental, is introduced in the job matrix to distinguish between different MediaWiki versions. The changes set experimental to false for specified release versions and true for the master branch. In addition, the test job now uses the continue-on-error property based on this parameter, and the PHP version for the master branch is updated from 8.2 to 8.4. The README file is updated to reflect new version constraints for PHP and MediaWiki.

Changes

File Change Summary
.github/workflows/ci.yml Added the experimental parameter in the test job matrix with values: false for REL1_39, REL1_41, REL1_42, REL1_43 and true for master; introduced continue-on-error: ${{ matrix.experimental }}; updated PHP version for master from 8.2 to 8.4.
README.md Updated PHP version from "tested up to 8.2" to "tested up to 8.3"; updated MediaWiki version from "tested up to 1.42-dev" to "tested up to 1.43."

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
README.md (1)

60-61: Update Platform Requirements and Markdown Formatting

The updated lines now state:

  • "* [PHP] 8.1 or later (tested up to 8.3)"
  • "* [MediaWiki] 1.39 or later (tested up to 1.43)"

While these changes update the version compatibility details as intended, please verify that these version constraints align with your CI configuration. In particular, the CI configuration updates PHP to 8.4 on the master branch while the README now shows "tested up to 8.3"—ensure this inconsistency is intentional.

Additionally, static analysis (markdownlint MD004) recommends using dashes (-) rather than asterisks (*) for unordered list items. Consider revising the list markers as shown below:

-* [PHP] 8.1 or later (tested up to 8.3)
-* [MediaWiki] 1.39 or later (tested up to 1.43)
+ - [PHP] 8.1 or later (tested up to 8.3)
+ - [MediaWiki] 1.39 or later (tested up to 1.43)
🧰 Tools
🪛 markdownlint-cli2 (0.17.2)

60-60: Unordered list style
Expected: dash; Actual: asterisk

(MD004, ul-style)


61-61: Unordered list style
Expected: dash; Actual: asterisk

(MD004, ul-style)

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 335a42f and e1786f2.

📒 Files selected for processing (1)
  • README.md (1 hunks)
🧰 Additional context used
🪛 markdownlint-cli2 (0.17.2)
README.md

60-60: Unordered list style
Expected: dash; Actual: asterisk

(MD004, ul-style)


61-61: Unordered list style
Expected: dash; Actual: asterisk

(MD004, ul-style)

@JeroenDeDauw JeroenDeDauw merged commit b5c6f1d into master Feb 24, 2025
17 checks passed
@JeroenDeDauw JeroenDeDauw deleted the malberts-patch-1 branch February 24, 2025 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants