Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Schwarzschild cell-width calculation #614

Merged
merged 1 commit into from
Aug 14, 2024
Merged

Conversation

c-white
Copy link
Contributor

@c-white c-white commented Aug 13, 2024

x1-array was accidentally used in place of x2-array, but indexed with j. As cell widths only affect relativity for timestep purposes, and as most simulations use horizon-penetrating coordinates, this had little effect except when non-square MeshBlocks would cause crashes.

Fixes #613

x1-array was accidentally used in place of x2-array, but indexed with j.
As cell widths only affect relativity for timestep purposes, and as most
simulations use horizon-penetrating coordinates, this had little effect
except when non-square MeshBlocks would cause crashes.

Fixes #613
@c-white c-white added bug Broken functionality or unexpected result GR/SR Relating to general and special relativity components labels Aug 13, 2024
@c-white c-white requested a review from felker August 13, 2024 21:24
@c-white c-white self-assigned this Aug 13, 2024
@felker felker merged commit ad81123 into master Aug 14, 2024
1 check passed
@felker felker deleted the schwarzschild_fix branch September 10, 2024 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Broken functionality or unexpected result GR/SR Relating to general and special relativity components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug found in the coordinate class for schwarzschild geometry
2 participants