[ACCOUNT-2797] refactor: remove guzzle dependency #468
+4,172
−2,182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # .github/workflows/accounts-qc-php.yml # .zip-contents # Makefile # composer.json # composer.lock # config.local.php # config.preprod.php # config/admin/services.yml # config/common.yml # config/front/services.yml # ps_accounts.php
# Conflicts: # _dev/package.json # config.xml # ps_accounts.php
hschoenenberger
commented
Feb 27, 2025
| $oauth2Client = $this->getOAuth2Client(); | ||
|
|
||
| $logoutUrl = $oauth2Client->getLogoutUri( | ||
| $oauth2Client->getPostLogoutRedirectUri(), |
There was a problem hiding this comment.
Decide if we also allow setting alternative postLoginUri with login flow
src/Http/Client/Curl/Client.php
Outdated
| /** | ||
| * @var string | ||
| */ | ||
| protected $userAgent = 'ps_accounts/' . \Ps_accounts::VERSION; |
There was a problem hiding this comment.
Header string to be decided with the team
|
|
||
| return $this->getSafeResponse($ch); | ||
| } | ||
|
|
| } else { | ||
| $decodedBody = json_decode($body, true); | ||
|
|
||
| return is_array($decodedBody) ? $decodedBody : []; |
There was a problem hiding this comment.
We expect only json object / list
src/OAuth2/ApiClient.php
Outdated
| * | ||
| * @throws OAuth2Exception | ||
| */ | ||
| public function getAuthorizationUri( |
There was a problem hiding this comment.
Allow to specify another redirect uri here ?
| @@ -0,0 +1,33 @@ | |||
| <?php | |||
|
|
|||
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To go a step further reducing friction with the PrestaShop module's ecosystem, reducing module weight.
As a module we just need to do a few things, not to embed huge libraries so let's get straight to the point and isolate a much a possible from other modules to avoid collisions, also stay lighter.
Still a POC, but fully functional.
Benefits: