Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Viewport check: 320px #340

Closed
mparvazi opened this issue Jul 8, 2022 · 17 comments · Fixed by #357 or #627
Closed

Viewport check: 320px #340

mparvazi opened this issue Jul 8, 2022 · 17 comments · Fixed by #357 or #627
Labels
Bug Something isn't working Good first issue Good for newcomers Mobile Small screen sizes Responsive Only happens on small resolutions

Comments

@mparvazi
Copy link
Member

mparvazi commented Jul 8, 2022

Header logo

The logo container display must be defined as block, in current implementation there is overlap with search icon if the logo width is more than 150px.

logo

User menu button (Fixed by #343)

When customer is not logged-in there is an unwanted right padding, so we have extra space on the right side.

user

Newsletter block

Need to use full-width style for input elements.

newsletter

Pagination

We have overflow when Next and Previous buttons are displayed at the same time. I think we need to hide text label for mobile screen.

pagination

Account page (Fixed by #357)

It's better to use an unstyle button for Back and place it under the page title.

back

Products list

Just a suggestion: showing one product per column on mobile screen.

products

@mparvazi mparvazi added Responsive Only happens on small resolutions Mobile Small screen sizes labels Jul 8, 2022
@NeOMakinG NeOMakinG added Good first issue Good for newcomers Bug Something isn't working labels Jul 8, 2022
@mparvazi
Copy link
Member Author

mparvazi commented Jul 8, 2022

I tried to change pagination display for XS screen with current design, but not works for big page numbers:

Screenshot from 2022-07-08 23-35-16

@mparvazi
Copy link
Member Author

mparvazi commented Jul 8, 2022

Wdyt about this?
A compact version for XS screen:

Screenshot from 2022-07-09 00-11-10

Support page numbers until 999 :P

@mparvazi
Copy link
Member Author

I used pagination like this for ps 1.6 theme and it works fine:

Screenshot 2022-07-10 113428

Screenshot 2022-07-10 113340

@SharakPL
Copy link
Contributor

SharakPL commented Jul 10, 2022

I like that last one!
The compact one begs a question:
obraz
Does it go to previous page or to 1st?

Previous/next buttons are obsolete if it would look like this:
obraz

@Hlavtox
Copy link
Contributor

Hlavtox commented Jul 10, 2022

Yeah, the prev/next ones maybe can go on mobile, or we can put them to next line, that also looks good.

@mparvazi
Copy link
Member Author

Can we decrease page numbers on left and right side of selected page? (for mobile by css tricks)
178153562-37014f19-48ed-46b6-ba08-1e58c7f91a77

I mean change it to:
< 11 | 7 (6) 5 | 1 >

@SharakPL
Copy link
Contributor

Imo the top version is better since < and > are just duplications for 7 and 5 in this case. Top one gives more options to the user without taking more space.

@mparvazi
Copy link
Member Author

@NeOMakinG Wdyt?

Desktop, tablet:

178134836-9cb1e8c5-2bfd-4b81-8a8d-abc7cb808fac_2

or

178134836-9cb1e8c5-2bfd-4b81-8a8d-abc7cb808fac

Mobile:

178134841-d0081917-505d-4abe-bbbc-31af9cdffea1

@NeOMakinG
Copy link
Contributor

Imo the top version is better since < and > are just duplications for 7 and 5 in this case. Top one gives more options to the user without taking more space.

I guess it's not about duplication but make it more accessible with your finders, it's easier to click on a <> button than on a number on mobile

@NeOMakinG
Copy link
Contributor

@TristanLDD can we have your input on this?

@SharakPL
Copy link
Contributor

Imo the top version is better since < and > are just duplications for 7 and 5 in this case. Top one gives more options to the user without taking more space.

I guess it's not about duplication but make it more accessible with your finders, it's easier to click on a <> button than on a number on mobile

Actually it's all the same :) and if it's about having < and > in the mix then maybe we should use the most obvious:

| « | ‹ | 6 | › | » |

@NeOMakinG
Copy link
Contributor

Go for the most obvious one anyway, if the product or design team wants to set some feedback later, they'll do it, 100% trusting both of you on this subject ;)

@mparvazi
Copy link
Member Author

mparvazi commented Jul 21, 2022

Fix for logo block.
Wdyt?

    {* index *}
    <h1 class="m-0 d-inline-flex">
      <a class="navbar-brand">
        <img class="logo" src="" width="x" height="y">
      </a>
    </h1>

    {* other pages *}
    <a class="navbar-brand">
      <img class="logo" src="" width="x" height="y">
    </a>
    // desktop
    .navbar-brand {
      .logo {
        width: auto;
        max-height: 4rem;
      }
    }

    // mobile
    .navbar-brand {
      .logo {
        width: auto;
        max-height: 2rem;
      }
    }

Before

Screencast-from-07-21-2022-01_08_47-PM.mp4

After

Screencast-from-07-21-2022-01_21_22-PM.mp4

@NeOMakinG
Copy link
Contributor

NeOMakinG commented Jul 25, 2022

Looks fine to me, I don't see any blockers!

@NeOMakinG NeOMakinG reopened this Jul 25, 2022
lucrp added a commit to lucrp/hummingbird that referenced this issue Oct 25, 2022
Hide text label for mobile screen, by issue PrestaShop#340
@eshraw eshraw moved this to 🏗 In progress in Hummingbird release flightpath Nov 17, 2022
@eshraw eshraw moved this from 🏗 In progress to 🔖 Ready in Hummingbird release flightpath Nov 18, 2022
@JBLach
Copy link
Contributor

JBLach commented Dec 1, 2022

I will improve the view of the newsletter.

@JBLach
Copy link
Contributor

JBLach commented Dec 8, 2022

I will improve the view of the newsletter.

Oh now I see that the newsletter has already been corrected and it looks good

@NeOMakinG
Copy link
Contributor

I will improve the view of the newsletter.

Oh now I see that the newsletter has already been corrected and it looks good

Oh, I don't even remember who did this but that's cool then!

@Zoefinders Zoefinders moved this from 🔖 Ready to 📋 Backlog in Hummingbird release flightpath Apr 3, 2023
@tblivet tblivet mentioned this issue May 17, 2024
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Hummingbird release flightpath Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Good first issue Good for newcomers Mobile Small screen sizes Responsive Only happens on small resolutions
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

5 participants