Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding AC problems for runestone testing #2424

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Tanaquil18
Copy link
Contributor

These are the problems (with my commentary) Matt and I had identified 1.5 years ago as problematic or previously problematic and good for testing. I built it as part of a separate project at that time, deployed here, but I haven't tried building either as part of this repository or at all since that time.

@rbeezer
Copy link
Collaborator

rbeezer commented Feb 28, 2025

Thanks for formulating this PR. Very sorry if I missed this contribution in some other format.

The problems that are in the csafranski directory are not going to generally be available. This sample gets tested with lots of servers (different versions, different hosts) so we can't assume prolems placed this way. Nor do we have any control over the stability of their contents.

Should I proceed and just remove those few problems?

@Alex-Jordan
Copy link
Contributor

When #2336 is merged, local .pg files become usable. As in, local to your computer. I can't think right off top of my head if they are usable with a 2.18-or-below server, but definitely usable with 2.19. So the csafranski problems could come in at that time.

@bnmnetp
Copy link
Contributor

bnmnetp commented Feb 28, 2025

Since Chrissy's questions are on the runestone webwork server and are illustrative of problem areas we experienced it would be good to have them in there.

Could we create a RunestoneAcademy version that would include said questions when built for RA?

Maybe the solution Alex just proposed as I was typing this is better.

@rbeezer
Copy link
Collaborator

rbeezer commented Feb 28, 2025

OK, @bnmnetp wants them all. @Tanaquil18: could you rewtite the six problems from csafranski in PreTeXt source syntax, much like the (big) ajordan_8a-_2_Preview_sine_Taylor problem?

That would really be the best for using this for testing, on and off, Runestone. Versions are a possibility, but come with their own baggage.

@Alex-Jordan
Copy link
Contributor

If anything is going to be rewritten here anyway...

I would appreciate it if you can tend to the indentation. I have to work with this file a lot and it's helpful to have it logically indented.

Another thing: there are large blocks of content commented out here. (Some solutions, at least one exercise, maybe more.) Would you go through and make decisions to (a) uncomment them (b) delete them, or (c) intentionally decide it is best to keep them commented? There should be a compelling reason for doing (c) that is explained in a comment.

Some "exercise" have a label, some do not. Best to go ahead now and give all of them a label.

Some of these are OPL problem files and I am uncertain about if these belong here. Because in some cases (at minimum, the last two) the issue is not our issue. It's entirely how badly the OPL problem was coded. I don't have advice for what to do about this (leave the OPL problems in this PR versus take them out) but I thought it worth mentioning.

@rbeezer
Copy link
Collaborator

rbeezer commented Feb 28, 2025

Thanks, @Alex-Jordan. Yes, nothing should be commentd out - it confuses testing when you are looking (grep'ing) for problems.

And, if a problem is in the OPL and not authored in a way PreTeXt can digest it, then it doesn't belong here.

@Tanaquil18
Copy link
Contributor Author

Tanaquil18 commented Mar 1, 2025 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants