-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: safer rrweb events and regular full snapshots #973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Change: +3.69 kB (0%) Total Size: 766 kB
ℹ️ View Unchanged
|
marandaneto
reviewed
Jan 28, 2024
marandaneto
reviewed
Jan 28, 2024
marandaneto
reviewed
Jan 28, 2024
marandaneto
approved these changes
Jan 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few comments but LGTM.
If we see that this improves something (eg player performance) or at least helps us debug things, I can do the very same on Mobile.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
regular full snapshots
we currently only take a full snapshot at the start of a recording or on return from idle
so if someone has an active and complex 20 minute recording we accrue 20 minutes of incremental snapshots. this has performance impact on playback and on seeking
instead now, when we start recording we set an interval to take another full snapshot in 5 minutes
if we see a fullsnapshot before that we reset the timer, so that we would take a full snapshot 5 minutes after that
safer rrweb events
we believe we are missing full snapshots and custom events - maybe on return from idle
this adds a simple in-memory queue so that if we cannot take one of these triggered events, we will retry the next time rrweb emits an event
it also adds a custom event to report this happened so that we can track how often and by how much this is happening (cos it might not help 🤷)