Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(surveys): Accept eventPayload in onEvent handler #1331

Merged
merged 1 commit into from
Jul 30, 2024

Conversation

Phanatic
Copy link
Contributor

Changes

This is a bug fix for the scenario where we weren't removing a survey from the activated surveys list once the survey is shown.

Checklist

  • Tests for new code (see advice on the tests we use)
  • Accounted for the impact of any changes across different browsers
  • Accounted for backwards compatibility of any changes (no breaking changes in posthog-js!)

Copy link

vercel bot commented Jul 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
posthog-js ✅ Ready (Inspect) Visit Preview Jul 30, 2024 5:41pm

@Phanatic Phanatic requested a review from a team July 30, 2024 17:38
@Phanatic Phanatic changed the title fix(surveys) : Accept eventPayload in onEvent handler fix(surveys): Accept eventPayload in onEvent handler Jul 30, 2024
Copy link

Size Change: +16 B (0%)

Total Size: 1.16 MB

Filename Size Change
dist/array.full.js 331 kB +4 B (0%)
dist/array.js 152 kB +4 B (0%)
dist/main.js 153 kB +4 B (0%)
dist/module.js 153 kB +4 B (0%)
ℹ️ View Unchanged
Filename Size
dist/exception-autocapture.js 10.4 kB
dist/recorder-v2.js 110 kB
dist/recorder.js 110 kB
dist/surveys-preview.js 59.7 kB
dist/surveys.js 64.9 kB
dist/tracing-headers.js 8.26 kB
dist/web-vitals.js 5.79 kB

compressed-size-action

Copy link
Contributor

@dmarticus dmarticus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rip it!!

@Phanatic Phanatic added the bump minor Bump minor version when this PR gets merged label Jul 30, 2024
@Phanatic Phanatic merged commit 47b43f5 into main Jul 30, 2024
13 of 14 checks passed
@Phanatic Phanatic deleted the remove-unstoppable-survey branch July 30, 2024 17:48
Phanatic pushed a commit that referenced this pull request Jul 31, 2024
This is a bug fix for the scenario where we weren't removing a survey from the activated surveys list once the survey is shown.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump minor Bump minor version when this PR gets merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants