feat: Added metadata saving in PPSimulation_2DContinuous #105
Conversation
There was a problem hiding this comment.
@Abhinavcode13 Looks good to me, thank you!
Left a few small comments. Once you're done, please run the pipeline and post a comment with the output from the console, and attach the resulting metadata file, so that we can verify that they match.
Thanks!!
| "sense_distance_grid": ppConfig.sense_distance / ppConfig.ppData.DOMAIN_SIZE[0] * ppConfig.TRACE_RESOLUTION[0], | ||
| "move_spread": ppConfig.steering_rate, | ||
| "sense_spread": ppConfig.sense_angle, | ||
| "persistence_coefficient": ppConfig.sampling_exponent, |
There was a problem hiding this comment.
this should be ppConfig.trace_attenuation and ppConfig.deposit_attenuation
...which means we now need 2 fields for this in the metadata - so let's call them the same as in the code please
There was a problem hiding this comment.
Thank you for the review, however I'm unsure what needs to done in this case.
"move_spread": ppConfig.trace_attenuation,
"sense_spread": ppConfig.deposit_attenuation,
Is this the correct way?
cc: @OskarElek
|
I thank you pointing it out, @OskarElek. I will address the adjustments in the upcoming PR. |
Fixes #81