Gtk DisplayActionSheet fix #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ports Bugzilla 58779 fix from MacOS to GTK
The numerical value looks nice, but XF on Droid and XF on iOS do not have this so for consistency it should be removed.
|
I've added 2nd commit for the numerical value on the slider (which should be hidden to be consistent with other Xam Forms targets) |
|
Thanks for your support and help!. Will review the PR. |
|
Hi. Just a reminder on this PR. |
|
Merged. Thank you very much for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
CHANGE 1
DisplayActionSheet on GTK had a bug if the number of buttons to show was large. The ActionSheet would be taller than the screen and some buttons and the cancel button were not visible.
This fix introduces a change to DisplayActionSheet on GTK so that the buttons are in a scroll window.
The same type of fix was needed in Xamarin Forms for MacOS recently.
CHANGE 2
The slider in GTK uses the native GTK widget that shows the numerical value of the slider.
It looks really nice but the other Xamarin Forms platforms do not show the value in the slider. They require the developer to create a User Interface showing the value.
So there is a patch to hide the numerical value on GTK.
Bugs Fixed
CHANGE 1.
Bugzilla 58779 reported the bug for ActionSheets with a large number of buttons on MacOS. This ports the same fix to GTK
CHANGE 2
No bugzilla report generated
API Changes
None
Behavioral Changes
ActionSheets with a large number of buttons e.g. over 20 buttons will now have a scroll window with scroll bars instead of getting a truncated list.
The Slider no longer shows the numerical value and is consistent with sliders on other platforms.
PR Checklist
is rebased on current upstream GTK fork