Isolate bug #37 with failing test

PhpGt · Aug 9, 2019 · cd71106 · cd71106
1 parent 6055467
commit cd71106
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 1 deletion.
diff --git a/test/unit/Helper/Helper.php b/test/unit/Helper/Helper.php
@@ -90,7 +90,7 @@ class Helper {
 			<input name="email" type="email" placeholder="e.g. j.smith@email.com" required />
 		</label>
 		<label>
-			<span>Your message</span>
+			<span data-ga-client="(Test) Message, this has a comma">Your message</span>
 			<textarea></textarea>
 		</label>
 		<label>

diff --git a/test/unit/TranslatorTest.php b/test/unit/TranslatorTest.php
@@ -309,4 +309,19 @@ public function testCommaSeparatedSelectors() {
 			$translator
 		);
 	}
+
+	public function testCommaInAttributeDoesNotSeparate() {
+		$document = new HTMLDocument(Helper::HTML_COMPLEX);
+		$emailTranslator = new Translator("[name=email]");
+		$messageTranslator = new Translator("[data-ga-client='(Test) Message, this has a comma']");
+
+		$emailItems = $document->xPath($emailTranslator);
+		$messageItems = $document->xPath($messageTranslator);
+
+		self::assertCount(1, $emailItems);
+		self::assertCount(1, $messageItems);
+
+		self::assertEquals("INPUT", strtoupper($emailItems[0]->tagName));
+		self::assertEquals("SPAN", strtoupper($messageItems[0]->tagName));
+	}
 }