-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adopt the centralized Xanadu Sphinx Theme #215
Conversation
Codecov Report
@@ Coverage Diff @@
## master #215 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 6 6
Lines 292 292
=========================================
Hits 292 292 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, @rmoyard! 🎉
I just have a few minor comments on some of the changes.
Co-authored-by: Mikhail Andrenkov <Mandrenkov@users.noreply.github.com>
…pennylane-qiskit into adopt_xanadu_sphinx
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks good to me! 🥳
Context:
Currently, all Xanadu OSS projects include their own version of the Xanadu Sphinx theme; however, the Xanadu Sphinx Theme repository is now publicly available and is the preferred way to access the Xanadu CSS theme and Sphinx directives.
Description of the Change:
Deleted the doc/xanadu_theme directory.
Updated doc/requirements.txt and doc/conf.py to reference and use the (centralized) Xanadu Sphinx Theme.
Benefits:
The size of this repository is smaller, meaning git clone will run faster.
Updates to the Xanadu Sphinx theme no longer have to be manually ported to this repository.
Possible Drawbacks:
None.