Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abbreviation of Thursday #16

Closed
karl-petter opened this issue May 14, 2015 · 4 comments
Closed

Abbreviation of Thursday #16

karl-petter opened this issue May 14, 2015 · 4 comments

Comments

@karl-petter
Copy link
Contributor

The abbreviation of Thursday in "ErrSunMonTueWedThrFriSat" on line 66 in DateStrings.cpp is Thr. Is this on purpose to be compatible with some specification? It is not compatible with the abbreviations used in RFC 2616 where Thu is used for Thursday. Caused me in interesting bugg which resulted in that my HMAC authentication worked on all days except Thursdays :)

@grayl
Copy link

grayl commented May 20, 2015

I agree with karl-petter. 'Thu' is the standard in the Canadian Forces, and as far as I know, all other English speaking forces in the world.

@PaulStoffregen
Copy link
Owner

@michaelmargolis Any thoughts on changing this? Seems like a pretty straightforward improvement.

@michaelmargolis
Copy link
Collaborator

I would be happy if you can make the change. I am in the middle of a house purchase and move so things will be frantic here until I get settled
Michael
Date: Wed, 20 May 2015 14:25:04 -0700
From: notifications@github.com
To: Time@noreply.github.com
CC: memargolis@hotmail.com
Subject: Re: [Time] Abbreviation of Thursday (#16)

@michaelmargolis Any thoughts on changing this? Seems like a pretty straightforward improvement.


Reply to this email directly or view it on GitHub.

@PaulStoffregen
Copy link
Owner

fixed
a7cc326

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants