Embraces angular2 styleguide #1091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-> *Component class name
-> *.{component|directive|service}.spec.ts test file names
|
tbd: |
|
tbd: styleguide also suggests to name e2e spec files with pattern: This requires a change in the webpack configuration. |
Closed
|
@dherges Some of the things suggested in style guides etc. are just taste. |
awcodify
pushed a commit
to awcodify/d3-angular-4
that referenced
this pull request
Aug 28, 2017
* Component class names follow the style guide * Filenames of services, components, and directives follow the style guide
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up on #1084
Spec file names, e.g.
x-large.spec.tsComponent class names e.g.
AppSpec file names, e.g.
x-large.directive.spec.tsComponent class names, e.g.
AppComponentSee
https://angular.io/styleguide#!#02-03
https://angular.io/styleguide#!#02-10
https://angular.io/styleguide#!#02-11
Styleguide also suggests to name e2e spec files with pattern:
<feature>.e2e-spec.ts, e.g.app.e2e-spec.ts