Fix clean-api-docs not deleting sidebar.ts #829
Merged
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
Running
clean-api-docs
doesn't delete the generated sidebar.ts file, this causes the file to not carry over changes whengen-api-docs
is ran. For now I have install & userimraf
to delete the sidebar.tsdocusaurus clean-api-docs all && rimraf <path>/sidebar.ts
How Has This Been Tested?
Used the local version of this branch in my typescript Docusaurus project, and confirmed
clean-api-docs
now deletes the sidebar.ts file without needingrimraf
.Types of changes
Updates the glob string used to match
sidebar
files.Originally
"sidebar.js"
was used. I updated it to"sidebar.{js,ts}"
You can test this glob here
Checklist