【Hackathon 5th No.11】为 Paddle 新增 igamma 和 igammac API RFC #625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zxcd
reviewed
Sep 18, 2023
| 测试需要考虑的 case 如下： | ||
|
|
||
| - 输出数值结果的一致性和数据类型是否正确，使用 scipy 作为参考标准 | ||
| - 对不同 dtype 的输入数据 `x` 进行计算精度检验 (float32, float64) |
There was a problem hiding this comment.
已添加相关内容， PyTorch中 CPU支持(float16, bfloat16, float32, float64)，GPU支持(float32, float64)
There was a problem hiding this comment.
那么在实现的时候时候是否可以也在CPU中支持float16, bfloat16？
There was a problem hiding this comment.
如果按照目前情况来看的话，float16, bfloat16的支持只需要在注册算子的时候添加相应的类型即可，并没有需要单独实现的部分
There was a problem hiding this comment.
已在API实现方案和底层OP设计中添加相应类型支持说明
zxcd
reviewed
Sep 18, 2023
|
|
||
| ## API实现方案 | ||
|
|
||
| 该 API 实现于 `python/paddle/tensor/manipulation.py`。 |
There was a problem hiding this comment.
python代码放在python/paddle/tensor/math.py，也给出c++代码实现位置
There was a problem hiding this comment.
这个函数应该是需要新增kernel，需要写出kernel实现的位置。
zxcd
reviewed
Sep 18, 2023
zxcd
reviewed
Sep 18, 2023
| $$ \gamma(a, x) = \int_0^x t^{a-1} e^{-t} dt $$ | ||
|
|
||
| 上不完全伽马函数 $\Gamma(a,x)$ 的定义域为 $a>0$，$x\geq 0$，值域为 $(0,\Gamma(a)]$。 | ||
| 下不完全伽马函数 $\gamma(a,x)$ 的定义域为 $a>0$，$x\geq 0$，值域为 $[0,\Gamma(a))$，其中 $\Gamma(a)$ 是伽马函数的值。 |
There was a problem hiding this comment.
上不完全伽马函数和下不完全伽马函数都是单调函数，因此值域只需要算边界值，当x=0时，上不完全伽马函数=Gamma(a)，下不完全伽马函数=0，当x趋于正无穷时，上不完全伽马函数趋近于0正，下不完全伽马函数趋近于Gamma(a)负，所以相应的值域就是(0,\Gamma(a)]和[0,\Gamma(a))
zxcd
approved these changes
Sep 21, 2023
|
LGTM |
luotao1
reviewed
Sep 21, 2023
|
|
||
| ### 实现基础计算逻辑 | ||
| 根据 igamma (上不完全伽马函数) 的定义，即 | ||
| $$ \Gamma(a, x) = \int_x^{\infty} t^{a-1} e^{-t} dt $$ |
luotao1
approved these changes
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.