-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Improvement] remove model_config_file and resource_files_names #3220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
为什么要删除?删除的逻辑如下: class A:
name = "model_config.json"
class B(A):
name = "model_config.json" 在派生类B中根本就没必要再重新把 在基类中定义的位置: PaddleNLP/paddlenlp/transformers/model_utils.py Lines 115 to 120 in f05794c
|
ping @guoshengCS |
guoshengCS
previously approved these changes
Sep 8, 2022
gptj是漏掉了吗? |
更新之后发现有三个新模型没有删除,我已经在新的commit中调整了。 你有时间可重新approve一下 @gongel |
gongel
approved these changes
Sep 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
optimization
PR changes
Models
Description
我发现在
PretrainedModel
的下游模型当中很多都有model_config_file
和resource_files_names
的配置,并且配置都是一样。而这些配置在基类PretrainedModel
里面其实是已经写了的,派生类中不需要再重复写,所以在这个PR当中我将其删掉。我在Bert单测上跑了相关单测,都通过了的。